From 10dea0c55d1f009da1745d71603e9c674d11891a Mon Sep 17 00:00:00 2001 From: Radu Ioan Fericean Date: Wed, 4 Dec 2013 21:25:36 +0200 Subject: [PATCH] show error on not enough credit when debiting --- engine/userbalance.go | 4 ++-- engine/userbalance_test.go | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/engine/userbalance.go b/engine/userbalance.go index 0cffab6a4..96695e8f1 100644 --- a/engine/userbalance.go +++ b/engine/userbalance.go @@ -472,8 +472,8 @@ func (ub *UserBalance) debitCreditBalance(cc *CallCost, count bool) error { ts.SplitByIncrement(incrementIndex) cc.Timespans = cc.Timespans[:tsIndex+1] } - //return errors.New("Not enough credit") - return nil + return errors.New("Not enough credit") + //return nil } } } diff --git a/engine/userbalance_test.go b/engine/userbalance_test.go index 9a8886a37..2c0cb6b03 100644 --- a/engine/userbalance_test.go +++ b/engine/userbalance_test.go @@ -327,8 +327,8 @@ func TestDebitCreditNoCredit(t *testing.T) { MINUTES + OUTBOUND: BalanceChain{b1}, }} err := rifsBalance.debitCreditBalance(cc, false) - if err != nil { - t.Error("Error debiting balance: ", err) + if err == nil { + t.Error("Showing no enough credit error ") } if cc.Timespans[0].Increments[0].BalanceUuids[0] != "testb" || cc.Timespans[0].Increments[0].Duration != time.Minute { @@ -556,8 +556,8 @@ func TestDebitCreditMoneyOnly(t *testing.T) { CREDIT + OUTBOUND: BalanceChain{&Balance{Uuid: "money", Value: 50}}, }} err := rifsBalance.debitCreditBalance(cc, false) - if err != nil { - t.Error("Error debiting balance: ", err) + if err == nil { + t.Error("Missing noy enough credit error ") } if cc.Timespans[0].Increments[0].BalanceUuids[0] != "money" ||