uppal/cgrates
1
0
Fork 1
mirror of https://github.com/cgrates/cgrates.git synced 2026-02-11 18:16:24 +05:00
Code Issues Packages Projects Releases Wiki Activity

Clone header before creating exporter HTTP request

Browse Source 
Behind http.Header is just a map and it's not safe for concurrent use.
Before this change, a panic might have occurred when doing asynchronous
HTTP exports (applies to both *http_post and *http_json_map exporters).
Cloning the header before adding it to the HTTP request has fixed this
issue.

Slightly improved the test that found this data race.
This commit is contained in:
ionutboangiu
2023-11-07 11:17:05 -05:00
committed by Dan Christian Bogos
parent c7e1f8f036
commit 29f58debc9
3 changed files with 27 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
ees/httpjsonmap.go
View File

@@ -96,7 +96,7 @@ func (httpEE *HTTPjsonMapEE) GetMetrics() *utils.SafeMapStorage { return httpEE.
func (httpEE *HTTPjsonMapEE) PrepareMap(mp *utils.CGREvent) (any, error) {
body, err := json.Marshal(mp.Event)
return &HTTPPosterRequest{
Header: httpEE.hdr,
Header: httpEE.hdr.Clone(),
Body: body,
}, err
}
@@ -111,7 +111,7 @@ func (httpEE *HTTPjsonMapEE) PrepareOrderMap(mp *utils.OrderedNavigableMap) (any
}
body, err := json.Marshal(valMp)
return &HTTPPosterRequest{
Header: httpEE.hdr,
Header: httpEE.hdr.Clone(),
Body: body,
}, err
}