From 353fc0544085ab8c9d9a87ed42f6b5d4a00728af Mon Sep 17 00:00:00 2001
From: ionutboangiu <ionut.boangiu@itsyscom.com>
Date: Fri, 11 Aug 2023 11:43:35 -0400
Subject: [PATCH] Update github workflows

In the integration_tests one, go is now installed using actions, therefore
the ansible go installation will be skipped.
---
 .github/workflows/build.yaml               | 13 +++++++------
 .github/workflows/integration_tests.yaml   |  8 ++++++--
 data/ansible/integration_tests/main.yaml   |  3 +--
 data/ansible/roles/cgrates/tasks/main.yaml |  4 ++--
 data/ansible/roles/go/defaults/main.yaml   |  1 +
 data/ansible/roles/go/tasks/main.yaml      | 15 +++++++++++----
 6 files changed, 28 insertions(+), 16 deletions(-)

diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
index d385588d3..e61850051 100644
--- a/.github/workflows/build.yaml
+++ b/.github/workflows/build.yaml
@@ -27,10 +27,12 @@ jobs:
     # needs: check-if-duplicate-action
     # if: needs.check-if-duplicate-action.outputs.should_skip != 'true'
     runs-on: ubuntu-latest
-    strategy:
-      fail-fast: true
-      matrix:
-        go: ["stable"] # could be a good idea to consider oldstable as well
+
+    ## Currently prefer to run tests for a single static go version
+    # strategy:
+    #   fail-fast: true
+    #   matrix:
+    #     go: ["stable"] # could be a good idea to consider oldstable as well
 
     steps:
       - name: Check out code
@@ -39,8 +41,7 @@ jobs:
       - name: Install Go
         uses: actions/setup-go@v4
         with:
-          go-version: ${{ matrix.go }}
-          check-latest: true
+          go-version: "1.21.0"
 
       - name: Go Format
         run: gofmt -s -w . && git diff --exit-code
diff --git a/.github/workflows/integration_tests.yaml b/.github/workflows/integration_tests.yaml
index 0bf29ad36..ed3c847cc 100644
--- a/.github/workflows/integration_tests.yaml
+++ b/.github/workflows/integration_tests.yaml
@@ -29,6 +29,11 @@ jobs:
       - name: Checkout code
         uses: actions/checkout@v3
 
+      - name: Install Go
+        uses: actions/setup-go@v4
+        with:
+          go-version: "1.21.0"
+
       - name: Setup Python
         uses: actions/setup-python@v4
         with:
@@ -41,11 +46,10 @@ jobs:
 
       - name: Run Ansible Playbook
         run: |
-          ansible-playbook data/ansible/integration_tests/main.yaml -i localhost, -c local -e "ansible_user=$(whoami) cgrates_dir=$GITHUB_WORKSPACE clone_repository=false"
+          ansible-playbook data/ansible/integration_tests/main.yaml -i localhost, -c local -e "ansible_user=$(whoami) cgrates_dir=$GITHUB_WORKSPACE clone_repository=false install_go=false"
 
       - name: Run integration tests
         run: |
           sudo su <<EOF
-          source /etc/profile
           ./integration_test.sh
           EOF
diff --git a/data/ansible/integration_tests/main.yaml b/data/ansible/integration_tests/main.yaml
index 72b393d89..76f251f1b 100644
--- a/data/ansible/integration_tests/main.yaml
+++ b/data/ansible/integration_tests/main.yaml
@@ -16,6 +16,5 @@
     - ../roles/kafka
     - ../roles/mongodb
     - ../roles/postgresql
-    - role: ../roles/go
-      when: install_go | bool | default(true)
+    - ../roles/go
     - ../roles/cgrates
diff --git a/data/ansible/roles/cgrates/tasks/main.yaml b/data/ansible/roles/cgrates/tasks/main.yaml
index 14b2aaf8d..47c66a353 100644
--- a/data/ansible/roles/cgrates/tasks/main.yaml
+++ b/data/ansible/roles/cgrates/tasks/main.yaml
@@ -13,7 +13,7 @@
     mode: "u=rwx,go=rx"
     owner: "{{ ansible_user }}"
     dest: "{{ cgrates_dir }}"
-  when: clone_repository | bool | default(true)
+  when: clone_repository | bool
 
 - name: Git clone cgrates
   ansible.builtin.git:
@@ -22,7 +22,7 @@
     update: yes
     force: yes
     version: "{{ git_version }}"
-  when: clone_repository | bool | default(true)
+  when: clone_repository | bool
 
 - name: Build cgrates
   ansible.builtin.shell:
diff --git a/data/ansible/roles/go/defaults/main.yaml b/data/ansible/roles/go/defaults/main.yaml
index d55f2347a..fe7ed0713 100644
--- a/data/ansible/roles/go/defaults/main.yaml
+++ b/data/ansible/roles/go/defaults/main.yaml
@@ -5,3 +5,4 @@ go_arch: amd64
 go_tarball: go{{ go_version }}.{{ go_platform }}-{{ go_arch }}.tar.gz
 go_download_url: https://dl.google.com/go/{{ go_tarball }}
 go_checksum: "d0398903a16ba2232b389fb31032ddf57cac34efda306a0eebac34f0965a0742"
+install_go: true
diff --git a/data/ansible/roles/go/tasks/main.yaml b/data/ansible/roles/go/tasks/main.yaml
index 1331122a9..32d8d7be0 100644
--- a/data/ansible/roles/go/tasks/main.yaml
+++ b/data/ansible/roles/go/tasks/main.yaml
@@ -10,27 +10,34 @@
     state: absent
     path: /usr/local/go
   when:
+    - install_go | bool
     - go_version_result is succeeded
     - go_version not in go_version_result.stdout
 
 - name: Download Go.
+  become: yes
   get_url:
     url: "{{ go_download_url }}"
     dest: /usr/local/src/{{ go_tarball }}
     checksum: "sha256:{{ go_checksum }}"
-  when: go_version_result is failed
-    or go_version not in go_version_result.stdout
+  when:
+    - install_go | bool
+    - (go_version_result is failed or go_version not in go_version_result.stdout)
 
 - name: Extract Go.
+  become: yes
   unarchive:
     src: /usr/local/src/{{ go_tarball }}
     dest: /usr/local
     copy: no
-  when: go_version_result is failed
-    or go_version not in go_version_result.stdout
+  when:
+    - install_go | bool
+    - (go_version_result is failed or go_version not in go_version_result.stdout)
 
 - name: Add Go to to system-wide $PATH.
+  become: yes
   copy:
     dest: /etc/profile.d/go-path.sh
     content: |-
       export PATH=$PATH:/usr/local/go/bin
+  when: install_go | bool