diff --git a/migrator/migrator_it_test.go b/migrator/migrator_it_test.go index 19eaddbf6..80a4f7e28 100644 --- a/migrator/migrator_it_test.go +++ b/migrator/migrator_it_test.go @@ -35,7 +35,7 @@ var ( cfg_in *config.CGRConfig cfg_out *config.CGRConfig Move = "move" - dbtype string + action string mig *Migrator dataDir = flag.String("data_dir", "/usr/share/cgrates", "CGR data dir path here") loadHistorySize = flag.Int("load_history_size", config.CgrConfig().LoadHistorySize, "Limit the number of records in the load history") @@ -132,7 +132,7 @@ func TestMigratorITPostgresConnect(t *testing.T) { } func TestMigratorITPostgres(t *testing.T) { - dbtype = utils.REDIS + action = utils.REDIS log.Print("REDIS+POSTGRES") for _, stest := range sTestsITMigrator { t.Run("TestITMigratorOnPostgres", stest) @@ -180,7 +180,7 @@ func TestMigratorITRedisConnect(t *testing.T) { } func TestMigratorITRedis(t *testing.T) { - dbtype = utils.REDIS + action = utils.REDIS log.Print("REDIS+MYSQL") for _, stest := range sTestsITMigrator { t.Run("TestITMigratorOnRedis", stest) @@ -228,7 +228,7 @@ func TestMigratorITMongoConnect(t *testing.T) { } func TestMigratorITMongo(t *testing.T) { - dbtype = utils.MONGO + action = utils.MONGO log.Print("MONGO") for _, stest := range sTestsITMigrator { t.Run("TestITMigratorOnMongo", stest) @@ -281,7 +281,7 @@ func TestMigratorITMoveConnect(t *testing.T) { } func TestMigratorITMove(t *testing.T) { - dbtype = Move + action = Move log.Print("Move") for _, stest := range sTestsITMigrator { t.Run("TestITMigratorOnMongo", stest) @@ -318,7 +318,7 @@ func testMigratorAccounts(t *testing.T) { Categories: utils.NewStringMap(), SharedGroups: utils.NewStringMap(), Timings: []*engine.RITiming{&engine.RITiming{Years: utils.Years{}, Months: utils.Months{}, MonthDays: utils.MonthDays{}, WeekDays: utils.WeekDays{}}}, TimingIDs: utils.NewStringMap(""), Factor: engine.ValueFactor{}} testAccount := &engine.Account{ID: "CUSTOMER_1:rif", BalanceMap: map[string]engine.Balances{utils.DATA: engine.Balances{v2d}, utils.VOICE: engine.Balances{v2b}, utils.MONETARY: engine.Balances{m2}}, UnitCounters: engine.UnitCounters{}, ActionTriggers: engine.ActionTriggers{}} switch { - case dbtype == utils.REDIS: + case action == utils.REDIS: err := mig.oldDataDB.setV1Account(v1Acc) if err != nil { t.Error("Error when setting v1 Accounts ", err.Error()) @@ -341,7 +341,7 @@ func testMigratorAccounts(t *testing.T) { } else if !reflect.DeepEqual(testAccount, result) { t.Errorf("Expecting: %+v, received: %+v", testAccount, result) } - case dbtype == utils.MONGO: + case action == utils.MONGO: err := mig.oldDataDB.setV1Account(v1Acc) if err != nil { t.Error("Error when marshaling ", err.Error()) @@ -362,7 +362,7 @@ func testMigratorAccounts(t *testing.T) { if !reflect.DeepEqual(testAccount, result) { t.Errorf("Expecting: %+v, received: %+v", testAccount, result) } - case dbtype == Move: + case action == Move: if err := mig.dmIN.DataDB().SetAccount(testAccount); err != nil { log.Print("GOT ERR DMIN", err) } @@ -389,7 +389,7 @@ func testMigratorActionPlans(t *testing.T) { v1ap := &v1ActionPlans{&v1ActionPlan{Id: "test", AccountIds: []string{"one"}, Timing: &engine.RateInterval{Timing: &engine.RITiming{Years: utils.Years{}, Months: utils.Months{}, MonthDays: utils.MonthDays{}, WeekDays: utils.WeekDays{}}}}} ap := &engine.ActionPlan{Id: "test", AccountIDs: utils.StringMap{"one": true}, ActionTimings: []*engine.ActionTiming{&engine.ActionTiming{Timing: &engine.RateInterval{Timing: &engine.RITiming{Years: utils.Years{}, Months: utils.Months{}, MonthDays: utils.MonthDays{}, WeekDays: utils.WeekDays{}}}}}} switch { - case dbtype == utils.REDIS: + case action == utils.REDIS: err := mig.oldDataDB.setV1ActionPlans(v1ap) if err != nil { t.Error("Error when setting v1 ActionPlan ", err.Error()) @@ -414,7 +414,7 @@ func testMigratorActionPlans(t *testing.T) { } else if ap.ActionTimings[0].Weight != result.ActionTimings[0].Weight || ap.ActionTimings[0].ActionsID != result.ActionTimings[0].ActionsID { t.Errorf("Expecting: %+v, received: %+v", ap.ActionTimings[0].Weight, result.ActionTimings[0].Weight) } - case dbtype == utils.MONGO: + case action == utils.MONGO: err := mig.oldDataDB.setV1ActionPlans(v1ap) if err != nil { t.Error("Error when setting v1 ActionPlans ", err.Error()) @@ -439,7 +439,7 @@ func testMigratorActionPlans(t *testing.T) { } else if ap.ActionTimings[0].Weight != result.ActionTimings[0].Weight || ap.ActionTimings[0].ActionsID != result.ActionTimings[0].ActionsID { t.Errorf("Expecting: %+v, received: %+v", ap.ActionTimings[0].Weight, result.ActionTimings[0].Weight) } - case dbtype == Move: + case action == Move: if err := mig.dmIN.DataDB().SetActionPlan(ap.Id, ap, true, utils.NonTransactional); err != nil { t.Error("Error when setting ActionPlan ", err.Error()) } @@ -499,7 +499,7 @@ func testMigratorActionTriggers(t *testing.T) { }, } switch { - case dbtype == utils.REDIS: + case action == utils.REDIS: err := mig.oldDataDB.setV1ActionTriggers(v1atrs) if err != nil { t.Error("Error when setting v1 ActionTriggers ", err.Error()) @@ -580,13 +580,13 @@ func testMigratorActionTriggers(t *testing.T) { } else if !reflect.DeepEqual(atrs[0].Balance.Blocker, result[0].Balance.Blocker) { t.Errorf("Expecting: %+v, received: %+v", atrs[0].Balance.Blocker, result[0].Balance.Blocker) } - case dbtype == utils.MONGO: + case action == utils.MONGO: err, _ := mig.Migrate([]string{utils.MetaActionTriggers}) if err != nil && err != utils.ErrNotImplemented { t.Error("Error when migrating ActionTriggers ", err.Error()) } - case dbtype == Move: + case action == Move: if err := mig.dmIN.SetActionTriggers(atrs[0].ID, atrs, utils.NonTransactional); err != nil { t.Error("Error when setting ActionPlan ", err.Error()) } @@ -710,7 +710,7 @@ func testMigratorActions(t *testing.T) { }, } switch { - case dbtype == utils.REDIS: + case action == utils.REDIS: err := mig.oldDataDB.setV1Actions(v1act) if err != nil { t.Error("Error when setting v1 Actions ", err.Error()) @@ -732,7 +732,7 @@ func testMigratorActions(t *testing.T) { t.Errorf("Expecting: %+v, received: %+v", *act, result) } - case dbtype == utils.MONGO: + case action == utils.MONGO: err := mig.oldDataDB.setV1Actions(v1act) if err != nil { t.Error("Error when setting v1 Actions ", err.Error()) @@ -753,7 +753,7 @@ func testMigratorActions(t *testing.T) { if !reflect.DeepEqual(*act, result) { t.Errorf("Expecting: %+v, received: %+v", *act, result) } - case dbtype == Move: + case action == Move: if err := mig.dmIN.SetActions((*v1act)[0].Id, *act, utils.NonTransactional); err != nil { t.Error("Error when setting ActionPlan ", err.Error()) } @@ -792,7 +792,7 @@ func testMigratorSharedGroups(t *testing.T) { MemberIds: utils.NewStringMap("1", "2", "3"), } switch { - case dbtype == utils.REDIS: + case action == utils.REDIS: err := mig.oldDataDB.setV1SharedGroup(v1sqp) if err != nil { t.Error("Error when setting v1 SharedGroup ", err.Error()) @@ -813,7 +813,7 @@ func testMigratorSharedGroups(t *testing.T) { if !reflect.DeepEqual(sqp, result) { t.Errorf("Expecting: %+v, received: %+v", sqp, result) } - case dbtype == utils.MONGO: + case action == utils.MONGO: err := mig.oldDataDB.setV1SharedGroup(v1sqp) if err != nil { t.Error("Error when setting v1 SharedGroup ", err.Error()) @@ -834,7 +834,7 @@ func testMigratorSharedGroups(t *testing.T) { if !reflect.DeepEqual(sqp, result) { t.Errorf("Expecting: %+v, received: %+v", sqp, result) } - case dbtype == Move: + case action == Move: if err := mig.dmIN.SetSharedGroup(sqp, utils.NonTransactional); err != nil { t.Error("Error when setting SharedGroup ", err.Error()) } @@ -940,7 +940,7 @@ func testMigratorStats(t *testing.T) { } } switch { - case dbtype == utils.REDIS: + case action == utils.REDIS: err := mig.oldDataDB.setV1Stats(v1Sts) if err != nil { t.Error("Error when setting v1Stat ", err.Error()) @@ -1009,7 +1009,7 @@ func testMigratorStats(t *testing.T) { if !reflect.DeepEqual(sq.ID, result2.ID) { t.Errorf("Expecting: %+v, received: %+v", sq.ID, result2.ID) } - case dbtype == utils.MONGO: + case action == utils.MONGO: err := mig.oldDataDB.setV1Stats(v1Sts) if err != nil { t.Error("Error when setting v1Stat ", err.Error()) @@ -1077,7 +1077,7 @@ func testMigratorStats(t *testing.T) { if !reflect.DeepEqual(sq.ID, result2.ID) { t.Errorf("Expecting: %+v, received: %+v", sq.ID, result2.ID) } - case dbtype == Move: + case action == Move: if err := mig.dmIN.SetStatQueueProfile(sqp); err != nil { t.Error("Error when setting Stats ", err.Error()) } @@ -1158,7 +1158,7 @@ func testMigratorThreshold(t *testing.T) { } switch { - case dbtype == utils.REDIS: + case action == utils.REDIS: if err := mig.dmIN.SetFilter(filter); err != nil { t.Error("Error when setting Filter ", err.Error()) } @@ -1196,7 +1196,7 @@ func testMigratorThreshold(t *testing.T) { if !reflect.DeepEqual(thp.ID, thpr.ID) { t.Errorf("Expecting: %+v, received: %+v", thp.ID, thpr.ID) } - case dbtype == utils.MONGO: + case action == utils.MONGO: if err := mig.dmIN.SetFilter(filter); err != nil { t.Error("Error when setting Filter ", err.Error()) } @@ -1234,7 +1234,7 @@ func testMigratorThreshold(t *testing.T) { if !reflect.DeepEqual(thp.ID, thpr.ID) { t.Errorf("Expecting: %+v, received: %+v", thp.ID, thpr.ID) } - case dbtype == Move: + case action == Move: if err := mig.dmIN.SetFilter(filter); err != nil { t.Error("Error when setting Filter ", err.Error()) } @@ -1304,7 +1304,7 @@ func testMigratorAlias(t *testing.T) { }, }, } - switch dbtype { + switch action { case Move: if err := mig.dmIN.DataDB().SetAlias(alias, utils.NonTransactional); err != nil { t.Error("Error when setting Alias ", err.Error()) @@ -1328,62 +1328,6 @@ func testMigratorAlias(t *testing.T) { } } -//WILL UPDATE AFTER RELEASE OF NEW ALIAS -//FIXME -// func testMigratorReverseAlias(t *testing.T) { -// alias := &engine.Alias{ -// Direction: "*out", -// Tenant: "cgrates.org", -// Category: "call", -// Account: "dan", -// Subject: "dan", -// Context: "*rating", -// Values: engine.AliasValues{ -// &engine.AliasValue{ -// DestinationId: "EU_LANDLINE", -// Pairs: engine.AliasPairs{ -// "Subject": map[string]string{ -// "dan": "dan1", -// "rif": "rif1", -// }, -// "Cli": map[string]string{ -// "0723": "0724", -// }, -// }, -// Weight: 10, -// }, - -// &engine.AliasValue{ -// DestinationId: "GLOBAL1", -// Pairs: engine.AliasPairs{"Subject": map[string]string{"dan": "dan2"}}, -// Weight: 20, -// }, -// }, -// } -// switch dbtype { -// case Move: -// if err := mig.dmIN.DataDB().SetReverseAlias(alias, utils.NonTransactional); err != nil { -// t.Error("Error when setting ReverseAlias ", err.Error()) -// } -// currentVersion := engine.CurrentDataDBVersions() -// err := mig.dmOut.DataDB().SetVersions(currentVersion, false) -// if err != nil { -// t.Error("Error when setting version for ReverseAlias ", err.Error()) -// } -// err, _ = mig.Migrate([]string{utils.MetaReverseAlias}) -// if err != nil { -// t.Error("Error when migrating ReverseAlias ", err.Error()) -// } -// result, err := mig.dmOut.DataDB().GetReverseAlias(alias.GetId(), true, utils.NonTransactional) -// if err != nil { -// t.Error("Error when getting ReverseAlias ", err.Error()) -// } -// if !reflect.DeepEqual(alias, result) { -// t.Errorf("Expecting: %+v, received: %+v", alias, result) -// } -// } -// } - func testMigratorCdrStats(t *testing.T) { cdrs := &engine.CdrStats{ Id: "", @@ -1411,7 +1355,7 @@ func testMigratorCdrStats(t *testing.T) { RatedSubject: []string{}, // CDRFieldFilter on RatedSubjects CostInterval: []float64{}, // CDRFieldFilter on CostInterval, 2 or less items, (>=Cost,