From 66477fd97cfa1d1727b9f240cfd770b51d0abff2 Mon Sep 17 00:00:00 2001
From: adragusin <adrian.dragusin@itsyscom.com>
Date: Wed, 20 Nov 2019 09:59:37 +0200
Subject: [PATCH] Updated tests in SharedGroup

---
 engine/sharedgroup.go      |  3 +++
 engine/sharedgroup_test.go | 18 +++++++++++-------
 2 files changed, 14 insertions(+), 7 deletions(-)

diff --git a/engine/sharedgroup.go b/engine/sharedgroup.go
index 1cbdb74fb..4d745416f 100644
--- a/engine/sharedgroup.go
+++ b/engine/sharedgroup.go
@@ -71,6 +71,9 @@ func (sg *SharedGroup) Clone() (sharedGroup *SharedGroup) {
 
 //Clone clones *SharingParameters
 func (sp *SharingParameters) Clone() *SharingParameters {
+	if sp == nil {
+		return nil
+	}
 	return &SharingParameters{
 		Strategy:      sp.Strategy,
 		RatingSubject: sp.RatingSubject,
diff --git a/engine/sharedgroup_test.go b/engine/sharedgroup_test.go
index 1a7529831..42447f512 100644
--- a/engine/sharedgroup_test.go
+++ b/engine/sharedgroup_test.go
@@ -25,8 +25,13 @@ import (
 )
 
 func TestSharedGroupClone(t *testing.T) {
+	//nil check
+	var sharedGroup *SharedGroup
+	if rcv := sharedGroup.Clone(); rcv != nil {
+		t.Errorf("Expecting: nil, received: %+v", utils.ToJSON(rcv))
+	}
 	//empty check
-	sharedGroup := &SharedGroup{}
+	sharedGroup = &SharedGroup{}
 	eOut := &SharedGroup{}
 	if rcv := sharedGroup.Clone(); !reflect.DeepEqual(eOut, rcv) {
 		t.Errorf("Expecting: %+v, received: %+v", utils.ToJSON(eOut), utils.ToJSON(rcv))
@@ -80,14 +85,13 @@ func TestSharedGroupClone(t *testing.T) {
 
 func TestSharingParametersClone(t *testing.T) {
 	//nil check
-	sharingParameters := &SharingParameters{}
-	eOut := &SharingParameters{}
-	if rcv := sharingParameters.Clone(); !reflect.DeepEqual(eOut, rcv) {
-		t.Errorf("Expecting: %+v, received: %+v", utils.ToJSON(eOut), utils.ToJSON(rcv))
+	var sharingParameters *SharingParameters
+	if rcv := sharingParameters.Clone(); rcv != nil {
+		t.Errorf("Expecting:nil, received: %+v", utils.ToJSON(rcv))
 	}
 	//empty check
-	sharingParameters = &SharingParameters{Strategy: "", RatingSubject: ""}
-	eOut = &SharingParameters{Strategy: "", RatingSubject: ""}
+	sharingParameters = &SharingParameters{}
+	eOut := &SharingParameters{}
 	if rcv := sharingParameters.Clone(); !reflect.DeepEqual(eOut, rcv) {
 		t.Errorf("Expecting: %+v, received: %+v", utils.ToJSON(eOut), utils.ToJSON(rcv))
 	}