From 77164ceaf1608ec0842fd2c2de288bcf1e92558d Mon Sep 17 00:00:00 2001 From: DanB Date: Mon, 29 Aug 2016 14:51:08 +0200 Subject: [PATCH] SMG - StoreSMCost error check fix, CDRS - Add syslog for errors served out of cache to detect key issues --- engine/cdrs.go | 1 + sessionmanager/smgeneric.go | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/engine/cdrs.go b/engine/cdrs.go index 46c28d8c0..70ccf54f6 100644 --- a/engine/cdrs.go +++ b/engine/cdrs.go @@ -531,6 +531,7 @@ func (self *CdrServer) V1StoreSMCost(attr AttrCDRSStoreSMCost, reply *string) er if item, err := self.getCache().Get(cacheKey); err == nil && item != nil { if item.Value != nil { *reply = item.Value.(string) + utils.Logger.Err(fmt.Sprintf(" Serving cached error for key: %s, err: %s", cacheKey, *reply)) } return item.Err } diff --git a/sessionmanager/smgeneric.go b/sessionmanager/smgeneric.go index 9184decd0..ab2b23d72 100644 --- a/sessionmanager/smgeneric.go +++ b/sessionmanager/smgeneric.go @@ -562,7 +562,7 @@ func (self *SMGeneric) ChargeEvent(gev SMGenericEvent, clnt *rpc2.Client) (maxDu OriginID: gev.GetUUID(), CostDetails: cc, } - if err := self.cdrsrv.Call("CdrsV1.StoreSMCost", engine.AttrCDRSStoreSMCost{Cost: smCost, CheckDuplicate: true}, &reply); err != nil && err != utils.ErrExists { + if err := self.cdrsrv.Call("CdrsV1.StoreSMCost", engine.AttrCDRSStoreSMCost{Cost: smCost, CheckDuplicate: true}, &reply); err != nil && err.Error() != utils.ErrExists.Error() { withErrors = true utils.Logger.Err(fmt.Sprintf(" Could not save CC: %+v, RunID: %s error: %s", cc, sR.DerivedCharger.RunID, err.Error())) }