From 798fc33bfc1805e618f297c1ecd9dcb37c132029 Mon Sep 17 00:00:00 2001 From: ionutboangiu Date: Wed, 18 Sep 2024 13:20:11 +0300 Subject: [PATCH] cgr-engine: Revise flag parsing error handling Use flag.ExitOnError for automatic error handling. Remove manual error check in main(). Set proper exit codes: 0 for help, 2 for parsing errors. Avoid misleading ' error' log on help requests. --- cmd/cgr-engine/cgr-engine.go | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/cmd/cgr-engine/cgr-engine.go b/cmd/cgr-engine/cgr-engine.go index ae68fb493..7cd0a0395 100644 --- a/cmd/cgr-engine/cgr-engine.go +++ b/cmd/cgr-engine/cgr-engine.go @@ -41,7 +41,7 @@ import ( ) var ( - cgrEngineFlags = flag.NewFlagSet("cgr-engine", flag.ContinueOnError) + cgrEngineFlags = flag.NewFlagSet("cgr-engine", flag.ExitOnError) cfgPath = cgrEngineFlags.String("config_path", utils.CONFIG_PATH, "Configuration directory path.") version = cgrEngineFlags.Bool("version", false, "Prints the application version.") checkConfig = cgrEngineFlags.Bool("check_config", false, "Verify the config without starting the engine") @@ -319,10 +319,7 @@ func singnalHandler(exitChan chan bool) { } func main() { - if err := cgrEngineFlags.Parse(os.Args[1:]); err != nil { - log.Fatalf("<%s> error received: <%s>, exiting!", utils.InitS, err.Error()) - return - } + cgrEngineFlags.Parse(os.Args[1:]) vers, err := utils.GetCGRVersion() if err != nil { log.Fatalf("<%s> error received: <%s>, exiting!", utils.InitS, err.Error())