Improving coverage tests

2026-02-11 18:16:24 +05:00 · 2023-05-05 11:00:31 -04:00
parent 11e2e2dbb8
commit 7a0ff57a36
4 changed files with 264 additions and 0 deletions
--- a/agents/agentreq_test.go
+++ b/agents/agentreq_test.go
@@ -2729,3 +2729,90 @@ func TestAgentRequestParseFieldDateTimeError2(t *testing.T) {
 		t.Errorf("Expected <%+v> but received <%+v>", expected, err)
 	}
 }
+
+func TestAgentRequestRemoveAll(t *testing.T) {
+	tntTpl := config.NewRSRParsersMustCompile("", utils.InfieldSep)
+	AgentReq := NewAgentRequest(utils.MapStorage{}, nil, nil, nil, nil, tntTpl, "", "", nil, nil)
+
+	testCases := []struct {
+		prefix  string
+		isError bool
+	}{
+		{prefix: utils.MetaVars, isError: false},
+		{prefix: utils.MetaCgreq, isError: false},
+		{prefix: utils.MetaCgrep, isError: false},
+		{prefix: utils.MetaRep, isError: false},
+		{prefix: utils.MetaDiamreq, isError: false},
+		{prefix: utils.MetaTmp, isError: false},
+		{prefix: utils.MetaUCH, isError: false},
+		{prefix: utils.MetaOpts, isError: false},
+		{prefix: "unsupported_prefix", isError: true},
+	}
+
+	for _, testCase := range testCases {
+		err := AgentReq.RemoveAll(testCase.prefix)
+		if testCase.isError && err == nil {
+			t.Fatalf("expected an error for prefix: <%s>, but got no error", testCase.prefix)
+		}
+		if !testCase.isError && err != nil {
+			t.Fatalf("expected no error for prefix: <%s>, but got error: %v", testCase.prefix, err)
+		}
+	}
+}
+
+func TestAgentRequestRemove(t *testing.T) {
+	tntTpl := config.NewRSRParsersMustCompile("", utils.InfieldSep)
+	AgentReq := NewAgentRequest(utils.MapStorage{}, nil, nil, nil, utils.MapStorage{utils.AccountField: "Field1"}, tntTpl, "", "", nil, nil)
+	testCases := []struct {
+		fullPath *utils.FullPath
+		isError  bool
+	}{
+		{fullPath: &utils.FullPath{PathSlice: []string{utils.MetaVars}, Path: utils.MetaVars + utils.NestingSep + utils.AccountField}, isError: false},
+		{fullPath: &utils.FullPath{PathSlice: []string{utils.MetaCgreq}, Path: utils.MetaCgreq + utils.NestingSep + utils.Usage}, isError: false},
+		{fullPath: &utils.FullPath{PathSlice: []string{utils.MetaCgrep}}, isError: false},
+		{fullPath: &utils.FullPath{PathSlice: []string{utils.MetaRep}, Path: utils.MetaRep + utils.NestingSep + "MaxUsage"}, isError: false},
+		{fullPath: &utils.FullPath{PathSlice: []string{utils.MetaDiamreq}, Path: utils.MetaDiamreq + utils.NestingSep + "Destination-Host"}, isError: false},
+		{fullPath: &utils.FullPath{PathSlice: []string{"unsupported_prefix"}}, isError: true},
+	}
+
+	for _, testCase := range testCases {
+		err := AgentReq.Remove(testCase.fullPath)
+		if testCase.isError && err == nil {
+			t.Fatalf("expected an error for fullPath: <%v>, but got no error", testCase.fullPath)
+		}
+		if !testCase.isError && err != nil {
+			t.Fatalf("expected no error for fullPath: <%v>, but got error: %v", testCase.fullPath, err)
+		}
+	}
+}
+
+// func TestAgentRequestAppend(t *testing.T) {
+// 	tntTpl := config.NewRSRParsersMustCompile("", utils.InfieldSep)
+// 	ar := NewAgentRequest(utils.MapStorage{}, &utils.DataNode{Type: utils.NMMapType, Map: map[string]*utils.DataNode{
+// 		utils.MetaAppID: utils.NewLeafNode("appID")}}, nil, nil, utils.MapStorage{utils.AccountField: "Field1"}, tntTpl, "", "", nil, nil)
+// 	testCases := []struct {
+// 		fullPath *utils.FullPath
+// 		val      *utils.DataLeaf
+// 		isError  bool
+// 	}{
+// 		{fullPath: &utils.FullPath{PathSlice: []string{utils.MetaVars}}, val: &utils.DataLeaf{Data: "test"}, isError: false},
+// 		{fullPath: &utils.FullPath{PathSlice: []string{utils.MetaCgreq}}, val: &utils.DataLeaf{Data: "test"}, isError: false},
+// 		{fullPath: &utils.FullPath{PathSlice: []string{utils.MetaCgrep}}, val: &utils.DataLeaf{Data: "test"}, isError: false},
+// 		{fullPath: &utils.FullPath{PathSlice: []string{utils.MetaRep}}, val: &utils.DataLeaf{Data: "test"}, isError: false},
+// 		{fullPath: &utils.FullPath{PathSlice: []string{utils.MetaDiamreq}}, val: &utils.DataLeaf{Data: "test"}, isError: false},
+// 		{fullPath: &utils.FullPath{PathSlice: []string{utils.MetaTmp}}, val: &utils.DataLeaf{Data: "test"}, isError: false},
+// 		{fullPath: &utils.FullPath{PathSlice: []string{utils.MetaOpts}}, val: &utils.DataLeaf{Data: "test"}, isError: false},
+// 		{fullPath: &utils.FullPath{PathSlice: []string{utils.MetaUCH}}, val: &utils.DataLeaf{Data: "test"}, isError: false},
+// 		{fullPath: &utils.FullPath{PathSlice: []string{"unsupported_prefix"}}, val: &utils.DataLeaf{Data: "test"}, isError: true},
+// 	}
+
+// 	for _, testCase := range testCases {
+// 		err := ar.Append(testCase.fullPath, testCase.val)
+// 		if testCase.isError && err == nil {
+// 			t.Fatalf("expected an error for fullPath: <%v>, but got no error", testCase.fullPath)
+// 		}
+// 		if !testCase.isError && err != nil {
+// 			t.Fatalf("expected no error for fullPath: <%v>, but got error: %v", testCase.fullPath, err)
+// 		}
+// 	}
+// }
--- a/agents/asterisk_event_test.go
+++ b/agents/asterisk_event_test.go
@@ -475,3 +475,55 @@ func TestRequestType(t *testing.T) {
 		t.Error("Received:", smaEv.RequestType())
 	}
 }
+
+func TestSMAsteriskEventUpdateCGREvent(t *testing.T) {
+	cgrEv := &utils.CGREvent{
+		Tenant: "cgrates.org",
+		ID:     "event1",
+		Event:  make(map[string]interface{}),
+	}
+
+	testCases := []struct {
+		smaEv     *SMAsteriskEvent
+		wantErr   bool
+		eventName string
+	}{
+		{
+			smaEv: &SMAsteriskEvent{
+				cachedFields: map[string]string{
+					eventType: ARIChannelStateChange,
+					timestamp: "2023-05-05T10:00:00Z",
+				},
+			},
+			wantErr:   false,
+			eventName: SMASessionStart,
+		},
+		{
+			smaEv: &SMAsteriskEvent{
+				cachedFields: map[string]string{
+					eventType: ARIChannelDestroyed,
+					timestamp: "2023-05-05T10:00:00Z",
+				},
+			},
+			wantErr:   false,
+			eventName: SMASessionTerminate,
+		},
+	}
+
+	for _, testCase := range testCases {
+		err := testCase.smaEv.UpdateCGREvent(cgrEv)
+		if testCase.wantErr && err == nil {
+			t.Fatal("expected an error, but got no error")
+		}
+		if !testCase.wantErr && err != nil {
+			t.Fatalf("expected no error, but got error: %v", err)
+		}
+
+		if !testCase.wantErr {
+			if eventName, ok := cgrEv.Event[utils.EventName]; !ok || eventName != testCase.eventName {
+				t.Fatalf("expected event name: %s, but got: %v", testCase.eventName, eventName)
+			}
+		}
+
+	}
+}