From 88dc20884167a4bc80c6940f84959c1910cd11fb Mon Sep 17 00:00:00 2001 From: TeoV Date: Fri, 2 Aug 2019 11:12:04 +0300 Subject: [PATCH] Rename filter "*accounts" to "*account" --- engine/filters.go | 8 ++++---- general_tests/filters_it_test.go | 4 ++-- utils/consts.go | 1 + 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/engine/filters.go b/engine/filters.go index e0414bc1e..cf5d55189 100644 --- a/engine/filters.go +++ b/engine/filters.go @@ -166,7 +166,7 @@ func (fS *FilterS) Pass(tenant string, filterIDs []string, conn = fS.statSConns case MetaResources, MetaNotResources: conn = fS.resSConns - case utils.MetaAccounts: + case utils.MetaAccount: conn = fS.ralSConns } if pass, err = fltr.Pass(ev, conn, tenant); err != nil || !pass { @@ -230,7 +230,7 @@ func NewFilterRule(rfType, fieldName string, vals []string) (*FilterRule, error) if !utils.IsSliceMember([]string{MetaString, MetaPrefix, MetaSuffix, MetaTimings, MetaRSR, MetaStatS, MetaDestinations, MetaEmpty, MetaExists, MetaLessThan, MetaLessOrEqual, MetaGreaterThan, - MetaGreaterOrEqual, MetaResources, MetaEqual, MetaNotEqual}, rType) { + MetaGreaterOrEqual, MetaResources, MetaEqual, utils.MetaAccount, MetaNotEqual}, rType) { return nil, fmt.Errorf("Unsupported filter Type: %s", rfType) } if fieldName == "" && utils.IsSliceMember([]string{MetaString, MetaPrefix, MetaSuffix, @@ -318,7 +318,7 @@ func (rf *FilterRule) CompileValues() (err error) { FilterValue: valSplt[2], } } - case utils.MetaAccounts: + case utils.MetaAccount: //value for filter of type *accounts needs to be in the following form: //*gt:AccountID:ValueOfUsage rf.accountItems = make([]*itemFilter, len(rf.Values)) @@ -372,7 +372,7 @@ func (fltr *FilterRule) Pass(dP config.DataProvider, result, err = fltr.passResourceS(dP, rpcClnt, tenant) case MetaEqual, MetaNotEqual: result, err = fltr.passEqualTo(dP) - case utils.MetaAccounts: + case utils.MetaAccount: result, err = fltr.passAccountS(dP, rpcClnt, tenant) default: err = utils.ErrPrefixNotErrNotImplemented(fltr.Type) diff --git a/general_tests/filters_it_test.go b/general_tests/filters_it_test.go index 51075c56c..51515b46f 100644 --- a/general_tests/filters_it_test.go +++ b/general_tests/filters_it_test.go @@ -526,7 +526,7 @@ func testV1FltrAccounts(t *testing.T) { ID: "FLTR_TH_Accounts", Rules: []*engine.FilterRule{ { - Type: "*accounts", + Type: "*account", Values: []string{"*gt:1001.BalanceMap.*monetary[0].Value:9"}, }, }, @@ -588,7 +588,7 @@ func testV1FltrAccounts(t *testing.T) { ID: "FLTR_TH_Accounts", Rules: []*engine.FilterRule{ { - Type: "*accounts", + Type: "*account", Values: []string{"*gt:1001.BalanceMap.*monetary[0].Value:11"}, }, }, diff --git a/utils/consts.go b/utils/consts.go index 453896748..e4d30a823 100755 --- a/utils/consts.go +++ b/utils/consts.go @@ -618,6 +618,7 @@ const ( MetaInit = "*init" MetaRatingPlanCost = "*rating_plan_cost" RatingPlanIDs = "RatingPlanIDs" + MetaAccount = "*account" ) // Migrator Action