From 909f56d58a077b57f5f7d0d378c1812cc1ae4fa9 Mon Sep 17 00:00:00 2001 From: arberkatellari Date: Mon, 12 Dec 2022 10:31:45 -0500 Subject: [PATCH] Improving loadConfigFromHTTP redundant URL parse --- config/config.go | 4 ---- config/config_test.go | 10 ---------- 2 files changed, 14 deletions(-) diff --git a/config/config.go b/config/config.go index 7faa65521..514a83da1 100644 --- a/config/config.go +++ b/config/config.go @@ -26,7 +26,6 @@ import ( "io" "net" "net/http" - "net/url" "os" "path/filepath" "runtime" @@ -1350,9 +1349,6 @@ func (cfg *CGRConfig) loadConfigFromFile(jsonFilePath string, loadFuncs []func(j func (cfg *CGRConfig) loadConfigFromHTTP(urlPaths string, loadFuncs []func(jsnCfg *CgrJsonCfg) error) (err error) { for _, urlPath := range strings.Split(urlPaths, utils.InfieldSep) { - if _, err = url.ParseRequestURI(urlPath); err != nil { - return - } var myClient = &http.Client{ Timeout: CgrConfig().GeneralCfg().ReplyTimeout, } diff --git a/config/config_test.go b/config/config_test.go index dfd1c5bc0..0413b8e1a 100644 --- a/config/config_test.go +++ b/config/config_test.go @@ -5551,16 +5551,6 @@ func TestCgrCfgJSONDefaultsConfigS(t *testing.T) { } } -func TestLoadConfigFromHTTP(t *testing.T) { - cfgCgr := NewDefaultCGRConfig() - - url := "inexistentURL" - expected := "parse \"inexistentURL\": invalid URI for request" - if err := cfgCgr.loadConfigFromHTTP(url, nil); err == nil || err.Error() != expected { - t.Errorf("Expected %+v, received %+v", expected, err) - } -} - func TestReloadSections(t *testing.T) { subsystemsThatNeedDataDB := utils.NewStringSet([]string{SCHEDULER_JSN, RALS_JSN, CDRS_JSN, SessionSJson, ATTRIBUTE_JSN,