From a4ea3eeae1d196cd540aa1feb49b529f335b50fe Mon Sep 17 00:00:00 2001 From: andronache Date: Thu, 21 Jan 2021 12:05:49 +0200 Subject: [PATCH] Added cover tests in console --- console/account_actionplan_get_test.go | 2 +- console/account_remove_test.go | 54 ++++++++++++++++++++++++++ console/account_set.go | 2 +- console/account_set_test.go | 54 ++++++++++++++++++++++++++ console/account_trigger_add_test.go | 54 ++++++++++++++++++++++++++ 5 files changed, 164 insertions(+), 2 deletions(-) create mode 100644 console/account_remove_test.go create mode 100644 console/account_set_test.go create mode 100644 console/account_trigger_add_test.go diff --git a/console/account_actionplan_get_test.go b/console/account_actionplan_get_test.go index 2fbe69017..68ae4f6e6 100644 --- a/console/account_actionplan_get_test.go +++ b/console/account_actionplan_get_test.go @@ -41,7 +41,7 @@ func TestCmdGetAccountActionPlan(t *testing.T) { } // verify the type of input parameter if ok := m.Type.In(1).AssignableTo(reflect.TypeOf(command.RpcParams(true))); !ok { - t.Fatalf("cannot assing intput parameter") + t.Fatalf("cannot assing input parameter") } // verify the type of output parameter if ok := m.Type.In(2).AssignableTo(reflect.TypeOf(command.RpcResult())); !ok { diff --git a/console/account_remove_test.go b/console/account_remove_test.go new file mode 100644 index 000000000..9e868307d --- /dev/null +++ b/console/account_remove_test.go @@ -0,0 +1,54 @@ +/* +Real-time Online/Offline Charging System (OCS) for Telecom & ISP environments +Copyright (C) ITsysCOM GmbH + +This program is free software: you can redistribute it and/or modify +it under the terms of the GNU General Public License as published by +the Free Software Foundation, either version 3 of the License, or +(at your option) any later version. + +This program is distributed in the hope that it will be useful, +but WITHOUT ANY WARRANTY; without even the implied warranty of +MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +GNU General Public License for more details. + +You should have received a copy of the GNU General Public License +along with this program. If not, see +*/ + +package console + +import ( + "reflect" + "strings" + "testing" + + "github.com/cgrates/cgrates/utils" + + v1 "github.com/cgrates/cgrates/apier/v1" +) + +func TestCmdRemoveAccount(t *testing.T) { + // commands map is initiated in init function + command := commands["account_remove"] + // verify if ApierSv1 object has method on it + m, ok := reflect.TypeOf(new(v1.APIerSv1)).MethodByName(strings.Split(command.RpcMethod(), utils.NestingSep)[1]) + if !ok { + t.Fatal("method not found") + } + if m.Type.NumIn() != 3 { // ApierSv1 is consider and we expect 3 inputs + t.Fatalf("invalid number of input parameters ") + } + // verify the type of input parameter + if ok := m.Type.In(1).AssignableTo(reflect.TypeOf(command.RpcParams(true))); !ok { + t.Fatalf("cannot assing input parameter") + } + // verify the type of output parameter + if ok := m.Type.In(2).AssignableTo(reflect.TypeOf(command.RpcResult())); !ok { + t.Fatalf("cannot assing output parameter") + } + // for coverage purpose + if err := command.PostprocessRpcParams(); err != nil { + t.Fatal(err) + } +} diff --git a/console/account_set.go b/console/account_set.go index a825afb33..5146d62f7 100644 --- a/console/account_set.go +++ b/console/account_set.go @@ -19,7 +19,7 @@ along with this program. If not, see package console import ( - "github.com/cgrates/cgrates/apier/v2" + v2 "github.com/cgrates/cgrates/apier/v2" "github.com/cgrates/cgrates/utils" ) diff --git a/console/account_set_test.go b/console/account_set_test.go new file mode 100644 index 000000000..f97a6a013 --- /dev/null +++ b/console/account_set_test.go @@ -0,0 +1,54 @@ +/* +Real-time Online/Offline Charging System (OCS) for Telecom & ISP environments +Copyright (C) ITsysCOM GmbH + +This program is free software: you can redistribute it and/or modify +it under the terms of the GNU General Public License as published by +the Free Software Foundation, either version 3 of the License, or +(at your option) any later version. + +This program is distributed in the hope that it will be useful, +but WITHOUT ANY WARRANTY; without even the implied warranty of +MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +GNU General Public License for more details. + +You should have received a copy of the GNU General Public License +along with this program. If not, see +*/ + +package console + +import ( + "reflect" + "strings" + "testing" + + v2 "github.com/cgrates/cgrates/apier/v2" + + "github.com/cgrates/cgrates/utils" +) + +func TestCmdSetAccount(t *testing.T) { + // commands map is initiated in init function + command := commands["account_set"] + // verify if ApierSv1 object has method on it + m, ok := reflect.TypeOf(new(v2.APIerSv2)).MethodByName(strings.Split(command.RpcMethod(), utils.NestingSep)[1]) + if !ok { + t.Fatal("method not found") + } + if m.Type.NumIn() != 3 { // ApierSv1 is consider and we expect 3 inputs + t.Fatalf("invalid number of input parameters ") + } + // verify the type of input parameter + if ok := m.Type.In(1).AssignableTo(reflect.TypeOf(command.RpcParams(true))); !ok { + t.Fatalf("cannot assing input parameter") + } + // verify the type of output parameter + if ok := m.Type.In(2).AssignableTo(reflect.TypeOf(command.RpcResult())); !ok { + t.Fatalf("cannot assing output parameter") + } + // for coverage purpose + if err := command.PostprocessRpcParams(); err != nil { + t.Fatal(err) + } +} diff --git a/console/account_trigger_add_test.go b/console/account_trigger_add_test.go new file mode 100644 index 000000000..08766a3c3 --- /dev/null +++ b/console/account_trigger_add_test.go @@ -0,0 +1,54 @@ +/* +Real-time Online/Offline Charging System (OCS) for Telecom & ISP environments +Copyright (C) ITsysCOM GmbH + +This program is free software: you can redistribute it and/or modify +it under the terms of the GNU General Public License as published by +the Free Software Foundation, either version 3 of the License, or +(at your option) any later version. + +This program is distributed in the hope that it will be useful, +but WITHOUT ANY WARRANTY; without even the implied warranty of +MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +GNU General Public License for more details. + +You should have received a copy of the GNU General Public License +along with this program. If not, see +*/ + +package console + +import ( + "reflect" + "strings" + "testing" + + v1 "github.com/cgrates/cgrates/apier/v1" + + "github.com/cgrates/cgrates/utils" +) + +func TestCmdAccountTriggerAdd(t *testing.T) { + // commands map is initiated in init function + command := commands["account_triggers_add"] + // verify if ApierSv1 object has method on it + m, ok := reflect.TypeOf(new(v1.APIerSv1)).MethodByName(strings.Split(command.RpcMethod(), utils.NestingSep)[1]) + if !ok { + t.Fatal("method not found") + } + if m.Type.NumIn() != 3 { // ApierSv1 is consider and we expect 3 inputs + t.Fatalf("invalid number of input parameters ") + } + // verify the type of input parameter + if ok := m.Type.In(1).AssignableTo(reflect.TypeOf(command.RpcParams(true))); !ok { + t.Fatalf("cannot assing input parameter") + } + // verify the type of output parameter + if ok := m.Type.In(2).AssignableTo(reflect.TypeOf(command.RpcResult())); !ok { + t.Fatalf("cannot assing output parameter") + } + // for coverage purpose + if err := command.PostprocessRpcParams(); err != nil { + t.Fatal(err) + } +}