From a9e0b9b67dd2941ef0992dfb865694bb5eed8f84 Mon Sep 17 00:00:00 2001 From: ionutboangiu Date: Fri, 14 Jul 2023 11:41:05 -0400 Subject: [PATCH] Update job names to be more descriptive, ignore go vet errors --- .github/workflows/build.yaml | 9 +++++---- .github/workflows/integration_tests.yaml | 8 ++++---- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index aad034257..f4f791896 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -10,7 +10,7 @@ on: jobs: - pre_job: + check-if-duplicate-action: # continue-on-error: true # Uncomment once integration is finished runs-on: ubuntu-latest outputs: @@ -24,10 +24,10 @@ jobs: paths_ignore: '["v0.10/docs/**"]' paths: '["v0.10/**.go", "v0.10/.github"]' - main_job: - name: Build + build: + needs: check-if-duplicate-action + if: needs.check-if-duplicate-action.outputs.should_skip != 'true' runs-on: ubuntu-latest - timeout-minutes: 5 strategy: fail-fast: true matrix: @@ -47,6 +47,7 @@ jobs: run: gofmt -s -w . && git diff --exit-code - name: Go Vet + continue-on-error: true # will soon be removed run: go vet ./... - name: Go Tidy diff --git a/.github/workflows/integration_tests.yaml b/.github/workflows/integration_tests.yaml index 42c110e9f..4cb439673 100644 --- a/.github/workflows/integration_tests.yaml +++ b/.github/workflows/integration_tests.yaml @@ -8,7 +8,7 @@ on: jobs: - pre_job: + check-if-duplicate-action: # continue-on-error: true # Uncomment once integration is finished runs-on: ubuntu-latest outputs: @@ -22,9 +22,9 @@ jobs: paths_ignore: '["v0.10/docs/**"]' paths: '["v0.10/**.go", "v0.10/*.sh", "v0.10/.github", "v0.10/data/ansible/conf/samples/**", "v0.10/data/tariffplans"]' - main_job: - needs: pre_job - if: needs.pre_job.outputs.should_skip != 'true' + integration-tests: + needs: check-if-duplicate-action + if: needs.check-if-duplicate-action.outputs.should_skip != 'true' runs-on: ubuntu-latest steps: - name: Checkout code