From ac8e909c79ce82551cc072239b24dcbd73df8eb0 Mon Sep 17 00:00:00 2001 From: ionutboangiu Date: Thu, 13 Jan 2022 09:41:39 +0200 Subject: [PATCH] Refactor GetFilters api --- apis/filters.go | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/apis/filters.go b/apis/filters.go index f86cd6087..78322a4ba 100644 --- a/apis/filters.go +++ b/apis/filters.go @@ -82,24 +82,23 @@ func (adms *AdminSv1) GetFilter(ctx *context.Context, arg *utils.TenantIDWithAPI return nil } -func (adms *AdminSv1) GetFilters(ctx *context.Context, args *utils.ArgsItemIDs, reply *[]*engine.Filter) (err error) { +// GetFilters returns a list of filters for a tenant +func (adms *AdminSv1) GetFilters(ctx *context.Context, args *utils.ArgsItemIDs, fltrs *[]*engine.Filter) (err error) { tnt := args.Tenant if tnt == utils.EmptyString { tnt = adms.cfg.GeneralCfg().DefaultTenant } var fltrIDs []string - err = adms.GetFilterIDs(ctx, args, &fltrIDs) - if err != nil { + if err = adms.GetFilterIDs(ctx, args, &fltrIDs); err != nil { return } - *reply = make([]*engine.Filter, 0, len(fltrIDs)) + *fltrs = make([]*engine.Filter, 0, len(fltrIDs)) for _, fltrID := range fltrIDs { var fltr *engine.Filter if fltr, err = adms.dm.GetFilter(ctx, tnt, fltrID, true, true, utils.NonTransactional); err != nil { return utils.APIErrorHandler(err) - } else { - *reply = append(*reply, fltr) } + *fltrs = append(*fltrs, fltr) } return }