Upgrade NATS driver version and implementation

Upgraded NATS server version in ansible role. upgraded go.mod nats version due to an issue caused by version mismatch between driver and server (uncertain). Increased amount of sleep in tests after starting a NATS server with jetstream enabled from 50ms to 100ms. ## *NatsER.Serve - Replaced ChanQueueSubscribe with QueueSubscribe for Core NATS consumer to handle the message processing directly. - Since QueueSubscribe is now used regardless of jetstream status, the message handler has been assigned to a separate variable that can be reused. - The message handler is now dealing with the message processing directly, therefore the select case listening for the channel which is feeding NATS messages can be removed together with the channel itself and the select. Currently, the goroutine within Serve only has to block until the rdrExit chan is closed. - Moved the resource check inside the handler right before starting the message processing goroutine. ## ers.getProcessedOptions - Renamed function from getProcessOptions to getProcessedOptions. - Initially, the EventExporterOpts struct was always initialized to be non-nil which meant exporting processed messages by the reader was always enabled by force. Function has been updated to initialize it only once when the first Processed option that was set is found. - Created init function for all types of opts structs to avoid repetition. ## *NatsEE.parseOpts - Renamed function from parseOpt to parseOpts. - Updated function to return early in case of nil opts struct to reduce nesting. - The nested jetstream status and maxwait conditions nil verification have been merged into one condition. - Handled the error coming from GetNatsOpts function. - NATS Subject assignment has been removed. It was redundant, since it had already been set from before this function was called. ## *NatsEE.Connect - Updated function to return early in case of non-nil nats.Conn value to reduce nesting. ## *NatsEE.ExportEvent - Use defer to release resources and RUnlock. ## *NatsEE.Close - Use defer to Unlock. - Update function to return early in case of nil nats.Conn value to reduce nesting. ## ees.GetNatsOpts - Chose switch over if else when parsing client certificate and keys opts. - Updated function to return the errors directly instead of assigning them to a separate variable right before returning. ## ers.GetNatsOpts - Passed the NATSROpts struct directly to the function. - Chose switch over if else when parsing client certificate and keys opts. - Updated function to return the errors directly instead of assigning them to a separate variable right before returning. Removed tab from commented natsJetStreamMaxWaitProcessed option value in config_defaults.go under ers section. Removed redundant NATS prefix from config.NATSROpts type field names. Added function in ers/lib_test.go to create a config file in /tmp based on a config string. Added integration test for ERs NATS.
2026-02-11 18:16:24 +05:00 · 2023-09-24 17:16:18 -04:00
parent 5d75b0e096
commit b1d68b6cfe
21 changed files with 698 additions and 469 deletions
--- a/ers/amqp.go
+++ b/ers/amqp.go
@@ -252,7 +252,7 @@ func (rdr *AMQPER) close() (err error) {
 }

 func (rdr *AMQPER) createPoster() {
-	processedOpt := getProcessOptions(rdr.Config().Opts)
+	processedOpt := getProcessedOptions(rdr.Config().Opts)
 	if processedOpt == nil && len(rdr.Config().ProcessedPath) == 0 {
 		return
 	}
--- a/ers/amqpv1.go
+++ b/ers/amqpv1.go
@@ -209,7 +209,7 @@ func (rdr *AMQPv1ER) close() (err error) {
 }

 func (rdr *AMQPv1ER) createPoster() {
-	processedOpt := getProcessOptions(rdr.Config().Opts)
+	processedOpt := getProcessedOptions(rdr.Config().Opts)
 	if processedOpt == nil && len(rdr.Config().ProcessedPath) == 0 {
 		return
 	}
--- a/ers/kafka.go
+++ b/ers/kafka.go
@@ -203,7 +203,7 @@ func (rdr *KafkaER) setOpts(opts *config.EventReaderOpts) (err error) {
 }

 func (rdr *KafkaER) createPoster() {
-	processedOpt := getProcessOptions(rdr.Config().Opts)
+	processedOpt := getProcessedOptions(rdr.Config().Opts)
 	if processedOpt == nil && len(rdr.Config().ProcessedPath) == 0 {
 		return
 	}
--- a/ers/lib_test.go
+++ b/ers/lib_test.go
@@ -19,9 +19,13 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>
 package ers

 import (
+	"crypto/rand"
 	"errors"
 	"flag"
+	"fmt"
+	"math/big"
 	"os"
+	"path/filepath"
 	"testing"

 	"github.com/cgrates/birpc"
@@ -80,3 +84,32 @@ func testCleanupFiles(t *testing.T) {
 		}
 	}
 }
+
+func initTestCfg(cfgContent string) (*config.CGRConfig, string, func(), error) {
+	folderNameSuffix, err := rand.Int(rand.Reader, big.NewInt(10000))
+	if err != nil {
+		return nil, "", nil, fmt.Errorf("could not generate random number for folder name suffix, err: %s", err.Error())
+	}
+	cfgPath := fmt.Sprintf("/tmp/config%d", folderNameSuffix)
+	err = os.MkdirAll(cfgPath, 0755)
+	if err != nil {
+		return nil, "", nil, err
+	}
+	filePath := filepath.Join(cfgPath, "cgrates.json")
+	err = os.WriteFile(filePath, []byte(cfgContent), 0644)
+	if err != nil {
+		os.RemoveAll(cfgPath)
+		return nil, "", nil, err
+	}
+	var cfg *config.CGRConfig
+	cfg, err = config.NewCGRConfigFromPath(cfgPath)
+	if err != nil {
+		os.RemoveAll(cfgPath)
+		return nil, "", nil, err
+	}
+	removeFunc := func() {
+		os.RemoveAll(cfgPath)
+	}
+
+	return cfg, cfgPath, removeFunc, nil
+}
--- a/ers/libers.go
+++ b/ers/libers.go
@@ -29,174 +29,167 @@ import (
 	"github.com/cgrates/cgrates/utils"
 )

-// getProcessOptions assigns all non-nil fields ending in "Processed" from EventReaderOpts to their counterparts in EventExporterOpts
-func getProcessOptions(erOpts *config.EventReaderOpts) (eeOpts *config.EventExporterOpts) {
-	eeOpts = new(config.EventExporterOpts)
-	if amqOpts := erOpts.AMQPOpts; amqOpts != nil {
-		if amqOpts.AMQPExchangeProcessed != nil {
+// getProcessedOptions assigns all non-nil fields ending in "Processed" from EventReaderOpts to their counterparts in EventExporterOpts
+func getProcessedOptions(erOpts *config.EventReaderOpts) *config.EventExporterOpts {
+	var eeOpts *config.EventExporterOpts
+
+	if erOpts.AMQPOpts != nil {
+		initAMQPExporterOpts := func() {
+			if eeOpts == nil {
+				eeOpts = new(config.EventExporterOpts)
+			}
 			if eeOpts.AMQP == nil {
 				eeOpts.AMQP = new(config.AMQPOpts)
 			}
-			eeOpts.AMQP.Exchange = amqOpts.AMQPExchangeProcessed
 		}
-		if amqOpts.AMQPExchangeTypeProcessed != nil {
-			if eeOpts.AMQP == nil {
-				eeOpts.AMQP = new(config.AMQPOpts)
-			}
-			eeOpts.AMQP.ExchangeType = amqOpts.AMQPExchangeTypeProcessed
+
+		if erOpts.AMQPOpts.AMQPExchangeProcessed != nil {
+			initAMQPExporterOpts()
+			eeOpts.AMQP.Exchange = erOpts.AMQPOpts.AMQPExchangeProcessed
 		}
-		if amqOpts.AMQPQueueIDProcessed != nil {
-			if eeOpts.AMQP == nil {
-				eeOpts.AMQP = new(config.AMQPOpts)
-			}
-			eeOpts.AMQP.QueueID = amqOpts.AMQPQueueIDProcessed
+		if erOpts.AMQPOpts.AMQPExchangeTypeProcessed != nil {
+			initAMQPExporterOpts()
+			eeOpts.AMQP.ExchangeType = erOpts.AMQPOpts.AMQPExchangeTypeProcessed
 		}
-		if amqOpts.AMQPRoutingKeyProcessed != nil {
-			if eeOpts.AMQP == nil {
-				eeOpts.AMQP = new(config.AMQPOpts)
-			}
-			eeOpts.AMQP.RoutingKey = amqOpts.AMQPRoutingKeyProcessed
+		if erOpts.AMQPOpts.AMQPQueueIDProcessed != nil {
+			initAMQPExporterOpts()
+			eeOpts.AMQP.QueueID = erOpts.AMQPOpts.AMQPQueueIDProcessed
 		}
-		if amqOpts.AMQPUsernameProcessed != nil {
-			if eeOpts.AMQP == nil {
-				eeOpts.AMQP = new(config.AMQPOpts)
-			}
-			eeOpts.AMQP.Username = amqOpts.AMQPUsernameProcessed
+		if erOpts.AMQPOpts.AMQPRoutingKeyProcessed != nil {
+			initAMQPExporterOpts()
+			eeOpts.AMQP.RoutingKey = erOpts.AMQPOpts.AMQPRoutingKeyProcessed
 		}
-		if amqOpts.AMQPPasswordProcessed != nil {
-			if eeOpts.AMQP == nil {
-				eeOpts.AMQP = new(config.AMQPOpts)
-			}
-			eeOpts.AMQP.Password = amqOpts.AMQPPasswordProcessed
+		if erOpts.AMQPOpts.AMQPUsernameProcessed != nil {
+			initAMQPExporterOpts()
+			eeOpts.AMQP.Username = erOpts.AMQPOpts.AMQPUsernameProcessed
 		}
-	}
-	if awsOpts := erOpts.AWSOpts; awsOpts != nil {
-		if awsOpts.AWSKeyProcessed != nil {
-			if eeOpts.AWS == nil {
-				eeOpts.AWS = new(config.AWSOpts)
-			}
-			eeOpts.AWS.Key = awsOpts.AWSKeyProcessed
-		}
-		if awsOpts.AWSRegionProcessed != nil {
-			if eeOpts.AWS == nil {
-				eeOpts.AWS = new(config.AWSOpts)
-			}
-			eeOpts.AWS.Region = awsOpts.AWSRegionProcessed
-		}
-		if awsOpts.AWSSecretProcessed != nil {
-			if eeOpts.AWS == nil {
-				eeOpts.AWS = new(config.AWSOpts)
-			}
-			eeOpts.AWS.Secret = awsOpts.AWSSecretProcessed
-		}
-		if awsOpts.AWSTokenProcessed != nil {
-			if eeOpts.AWS == nil {
-				eeOpts.AWS = new(config.AWSOpts)
-			}
-			eeOpts.AWS.Token = awsOpts.AWSTokenProcessed
-		}
-		if awsOpts.S3BucketIDProcessed != nil {
-			if eeOpts.AWS == nil {
-				eeOpts.AWS = new(config.AWSOpts)
-			}
-			eeOpts.AWS.S3BucketID = awsOpts.S3BucketIDProcessed
-		}
-		if awsOpts.S3FolderPathProcessed != nil {
-			if eeOpts.AWS == nil {
-				eeOpts.AWS = new(config.AWSOpts)
-			}
-			eeOpts.AWS.S3FolderPath = awsOpts.S3FolderPathProcessed
-		}
-		if awsOpts.SQSQueueIDProcessed != nil {
-			if eeOpts.AWS == nil {
-				eeOpts.AWS = new(config.AWSOpts)
-			}
-			eeOpts.AWS.SQSQueueID = awsOpts.SQSQueueIDProcessed
+		if erOpts.AMQPOpts.AMQPPasswordProcessed != nil {
+			initAMQPExporterOpts()
+			eeOpts.AMQP.Password = erOpts.AMQPOpts.AMQPPasswordProcessed
 		}
 	}

-	if kfkOpts := erOpts.KafkaOpts; kfkOpts != nil {
-		if kfkOpts.KafkaTopicProcessed != nil {
+	if erOpts.AWSOpts != nil {
+		initAWSExporterOpts := func() {
+			if eeOpts == nil {
+				eeOpts = new(config.EventExporterOpts)
+			}
+			if eeOpts.AWS == nil {
+				eeOpts.AWS = new(config.AWSOpts)
+			}
+		}
+
+		if erOpts.AWSOpts.AWSKeyProcessed != nil {
+			initAWSExporterOpts()
+			eeOpts.AWS.Key = erOpts.AWSOpts.AWSKeyProcessed
+		}
+		if erOpts.AWSOpts.AWSRegionProcessed != nil {
+			initAWSExporterOpts()
+			eeOpts.AWS.Region = erOpts.AWSOpts.AWSRegionProcessed
+		}
+		if erOpts.AWSOpts.AWSSecretProcessed != nil {
+			initAWSExporterOpts()
+			eeOpts.AWS.Secret = erOpts.AWSOpts.AWSSecretProcessed
+		}
+		if erOpts.AWSOpts.AWSTokenProcessed != nil {
+			initAWSExporterOpts()
+			eeOpts.AWS.Token = erOpts.AWSOpts.AWSTokenProcessed
+		}
+		if erOpts.AWSOpts.S3BucketIDProcessed != nil {
+			initAWSExporterOpts()
+			eeOpts.AWS.S3BucketID = erOpts.AWSOpts.S3BucketIDProcessed
+		}
+		if erOpts.AWSOpts.S3FolderPathProcessed != nil {
+			initAWSExporterOpts()
+			eeOpts.AWS.S3FolderPath = erOpts.AWSOpts.S3FolderPathProcessed
+		}
+		if erOpts.AWSOpts.SQSQueueIDProcessed != nil {
+			initAWSExporterOpts()
+			eeOpts.AWS.SQSQueueID = erOpts.AWSOpts.SQSQueueIDProcessed
+		}
+	}
+
+	if erOpts.KafkaOpts != nil {
+		if erOpts.KafkaOpts.KafkaTopicProcessed != nil {
+			if eeOpts == nil {
+				eeOpts = new(config.EventExporterOpts)
+			}
 			if eeOpts.Kafka == nil {
 				eeOpts.Kafka = new(config.KafkaOpts)
 			}
-			eeOpts.Kafka.KafkaTopic = kfkOpts.KafkaTopicProcessed
-		}
-	}
-	if natsOpts := erOpts.NATSOpts; natsOpts != nil {
-		if natsOpts.NATSCertificateAuthorityProcessed != nil {
-			if eeOpts.NATS == nil {
-				eeOpts.NATS = new(config.NATSOpts)
-			}
-			eeOpts.NATS.CertificateAuthority = natsOpts.NATSCertificateAuthorityProcessed
-		}
-		if natsOpts.NATSClientCertificateProcessed != nil {
-			if eeOpts.NATS == nil {
-				eeOpts.NATS = new(config.NATSOpts)
-			}
-			eeOpts.NATS.ClientCertificate = natsOpts.NATSClientCertificateProcessed
-		}
-		if natsOpts.NATSClientKeyProcessed != nil {
-			if eeOpts.NATS == nil {
-				eeOpts.NATS = new(config.NATSOpts)
-			}
-			eeOpts.NATS.ClientKey = natsOpts.NATSClientKeyProcessed
-		}
-		if natsOpts.NATSJWTFileProcessed != nil {
-			if eeOpts.NATS == nil {
-				eeOpts.NATS = new(config.NATSOpts)
-			}
-			eeOpts.NATS.JWTFile = natsOpts.NATSJWTFileProcessed
-		}
-		if natsOpts.NATSJetStreamMaxWaitProcessed != nil {
-			if eeOpts.NATS == nil {
-				eeOpts.NATS = new(config.NATSOpts)
-			}
-			eeOpts.NATS.JetStreamMaxWait = natsOpts.NATSJetStreamMaxWaitProcessed
-		}
-		if natsOpts.NATSJetStreamProcessed != nil {
-			if eeOpts.NATS == nil {
-				eeOpts.NATS = new(config.NATSOpts)
-			}
-			eeOpts.NATS.JetStream = natsOpts.NATSJetStreamProcessed
-		}
-		if natsOpts.NATSSeedFileProcessed != nil {
-			if eeOpts.NATS == nil {
-				eeOpts.NATS = new(config.NATSOpts)
-			}
-			eeOpts.NATS.SeedFile = natsOpts.NATSSeedFileProcessed
-		}
-		if natsOpts.NATSSubjectProcessed != nil {
-			if eeOpts.NATS == nil {
-				eeOpts.NATS = new(config.NATSOpts)
-			}
-			eeOpts.NATS.Subject = natsOpts.NATSSubjectProcessed
+			eeOpts.Kafka.KafkaTopic = erOpts.KafkaOpts.KafkaTopicProcessed
 		}
 	}

-	if sqlOpts := erOpts.SQLOpts; sqlOpts != nil {
-		if sqlOpts.SQLDBNameProcessed != nil {
-			if eeOpts.SQL == nil {
-				eeOpts.SQL = new(config.SQLOpts)
+	if erOpts.NATSOpts != nil {
+		initNATSExporterOpts := func() {
+			if eeOpts == nil {
+				eeOpts = new(config.EventExporterOpts)
 			}
-			eeOpts.SQL.DBName = sqlOpts.SQLDBNameProcessed
-		}
-		if sqlOpts.SQLTableNameProcessed != nil {
-			if eeOpts.SQL == nil {
-				eeOpts.SQL = new(config.SQLOpts)
+			if eeOpts.NATS == nil {
+				eeOpts.NATS = new(config.NATSOpts)
 			}
-			eeOpts.SQL.TableName = sqlOpts.SQLTableNameProcessed
-		}
-		if sqlOpts.PgSSLModeProcessed != nil {
-			if eeOpts.SQL == nil {
-				eeOpts.SQL = new(config.SQLOpts)
-			}
-			eeOpts.SQL.PgSSLMode = sqlOpts.PgSSLModeProcessed
 		}

+		if erOpts.NATSOpts.CertificateAuthorityProcessed != nil {
+			initNATSExporterOpts()
+			eeOpts.NATS.CertificateAuthority = erOpts.NATSOpts.CertificateAuthorityProcessed
+		}
+		if erOpts.NATSOpts.ClientCertificateProcessed != nil {
+			initNATSExporterOpts()
+			eeOpts.NATS.ClientCertificate = erOpts.NATSOpts.ClientCertificateProcessed
+		}
+		if erOpts.NATSOpts.ClientKeyProcessed != nil {
+			initNATSExporterOpts()
+			eeOpts.NATS.ClientKey = erOpts.NATSOpts.ClientKeyProcessed
+		}
+		if erOpts.NATSOpts.JWTFileProcessed != nil {
+			initNATSExporterOpts()
+			eeOpts.NATS.JWTFile = erOpts.NATSOpts.JWTFileProcessed
+		}
+		if erOpts.NATSOpts.JetStreamMaxWaitProcessed != nil {
+			initNATSExporterOpts()
+			eeOpts.NATS.JetStreamMaxWait = erOpts.NATSOpts.JetStreamMaxWaitProcessed
+		}
+		if erOpts.NATSOpts.JetStreamProcessed != nil {
+			initNATSExporterOpts()
+			eeOpts.NATS.JetStream = erOpts.NATSOpts.JetStreamProcessed
+		}
+		if erOpts.NATSOpts.SeedFileProcessed != nil {
+			initNATSExporterOpts()
+			eeOpts.NATS.SeedFile = erOpts.NATSOpts.SeedFileProcessed
+		}
+		if erOpts.NATSOpts.SubjectProcessed != nil {
+			initNATSExporterOpts()
+			eeOpts.NATS.Subject = erOpts.NATSOpts.SubjectProcessed
+		}
 	}

-	return
+	if erOpts.SQLOpts != nil {
+		initSQLExporterOpts := func() {
+			if eeOpts == nil {
+				eeOpts = new(config.EventExporterOpts)
+			}
+			if eeOpts.SQL == nil {
+				eeOpts.SQL = new(config.SQLOpts)
+			}
+		}
+
+		if erOpts.SQLOpts.SQLDBNameProcessed != nil {
+			initSQLExporterOpts()
+			eeOpts.SQL.DBName = erOpts.SQLOpts.SQLDBNameProcessed
+		}
+		if erOpts.SQLOpts.SQLTableNameProcessed != nil {
+			initSQLExporterOpts()
+			eeOpts.SQL.TableName = erOpts.SQLOpts.SQLTableNameProcessed
+		}
+		if erOpts.SQLOpts.PgSSLModeProcessed != nil {
+			initSQLExporterOpts()
+			eeOpts.SQL.PgSSLMode = erOpts.SQLOpts.PgSSLModeProcessed
+		}
+	}
+
+	return eeOpts
 }

 // mergePartialEvents will unite the events using the reader configuration
--- a/ers/libers_test.go
+++ b/ers/libers_test.go
@@ -32,7 +32,7 @@ func TestGetProcessOptions(t *testing.T) {
 			AMQPQueueIDProcessed: utils.StringPointer("processed"),
 		},
 	}
-	result := getProcessOptions(opts)
+	result := getProcessedOptions(opts)
 	expected := &config.EventExporterOpts{
 		AMQP: &config.AMQPOpts{
 			QueueID: utils.StringPointer("processed"),
--- a/ers/nats.go
+++ b/ers/nats.go
@@ -90,68 +90,85 @@ func (rdr *NatsER) Config() *config.EventReaderCfg {
 	return rdr.cgrCfg.ERsCfg().Readers[rdr.cfgIdx]
 }

-// Serve will start the gorutines needed to watch the nats subject
-func (rdr *NatsER) Serve() (err error) {
-	// Connect to a server
-	var nc *nats.Conn
-	var js nats.JetStreamContext
+// Serve will subscribe to a NATS subject and process incoming messages until the rdrExit channel
+// will be closed.
+func (rdr *NatsER) Serve() error {

-	if nc, err = nats.Connect(rdr.Config().SourcePath, rdr.opts...); err != nil {
-		return
+	// Establish a connection to the nats server.
+	nc, err := nats.Connect(rdr.Config().SourcePath, rdr.opts...)
+	if err != nil {
+		return err
 	}
-	ch := make(chan *nats.Msg)
+
+	// Define the message handler. Its content will get executed for every received message.
+	msgHandler := func(msg *nats.Msg) {
+
+		// If the rdr.cap channel buffer is empty, block until a resource is available. Otherwise
+		// allocate one resource and start processing the message.
+		if rdr.Config().ConcurrentReqs != -1 {
+			<-rdr.cap
+		}
+		go func(msg *nats.Msg) {
+			handlerErr := rdr.processMessage(msg.Data)
+			if handlerErr != nil {
+				utils.Logger.Warning(
+					fmt.Sprintf("<%s> processing message %s error: %s",
+						utils.ERs, string(msg.Data), handlerErr.Error()))
+			}
+
+			// Export the received message if a poster has been defined.
+			if rdr.poster != nil {
+				handlerErr = ees.ExportWithAttempts(rdr.poster, msg.Data, utils.EmptyString)
+				if handlerErr != nil {
+					utils.Logger.Warning(
+						fmt.Sprintf("<%s> writing message %s error: %s",
+							utils.ERs, string(msg.Data), handlerErr.Error()))
+				}
+			}
+
+			// Release the resource back to rdr.cap channel.
+			if rdr.Config().ConcurrentReqs != -1 {
+				rdr.cap <- struct{}{}
+			}
+		}(msg)
+	}
+
+	// Subscribe to the appropriate NATS subject.
 	if !rdr.jetStream {
-		if _, err = nc.ChanQueueSubscribe(rdr.subject, rdr.queueID, ch); err != nil {
-			return
+		_, err = nc.QueueSubscribe(rdr.subject, rdr.queueID, msgHandler)
+		if err != nil {
+			nc.Drain()
+			return err
 		}
 	} else {
+		var js nats.JetStreamContext
 		js, err = nc.JetStream(rdr.jsOpts...)
 		if err != nil {
-			return
+			nc.Drain()
+			return err
 		}
-		if _, err = js.QueueSubscribe(rdr.subject, rdr.queueID, func(msg *nats.Msg) {
-			ch <- msg
-		}, nats.Durable(rdr.consumerName)); err != nil {
-			return
+		_, err = js.QueueSubscribe(rdr.subject, rdr.queueID, msgHandler,
+			nats.Durable(rdr.consumerName))
+		if err != nil {
+			nc.Drain()
+			return err
 		}
 	}
+
 	go func() {
-		for {
-			if rdr.Config().ConcurrentReqs != -1 {
-				<-rdr.cap // do not try to read if the limit is reached
-			}
-			select {
-			case <-rdr.rdrExit:
-				utils.Logger.Info(
-					fmt.Sprintf("<%s> stop monitoring nats path <%s>",
-						utils.ERs, rdr.Config().SourcePath))
-				nc.Drain()
-				if rdr.poster != nil {
-					rdr.poster.Close()
-				}
-				return
-			case msg := <-ch:
-				go func(msg *nats.Msg) {
-					if err := rdr.processMessage(msg.Data); err != nil {
-						utils.Logger.Warning(
-							fmt.Sprintf("<%s> processing message %s error: %s",
-								utils.ERs, string(msg.Data), err.Error()))
-					}
-					if rdr.poster != nil { // post it
-						if err := ees.ExportWithAttempts(rdr.poster, msg.Data, utils.EmptyString); err != nil {
-							utils.Logger.Warning(
-								fmt.Sprintf("<%s> writing message %s error: %s",
-									utils.ERs, string(msg.Data), err.Error()))
-						}
-					}
-					if rdr.Config().ConcurrentReqs != -1 {
-						rdr.cap <- struct{}{}
-					}
-				}(msg)
-			}
+
+		// Wait for exit signal.
+		<-rdr.rdrExit
+		utils.Logger.Info(
+			fmt.Sprintf("<%s> stop monitoring nats path <%s>",
+				utils.ERs, rdr.Config().SourcePath))
+		nc.Drain()
+		if rdr.poster != nil {
+			rdr.poster.Close()
 		}
 	}()
-	return
+
+	return nil
 }

 func (rdr *NatsER) processMessage(msg []byte) (err error) {
@@ -187,7 +204,7 @@ func (rdr *NatsER) processMessage(msg []byte) (err error) {
 }

 func (rdr *NatsER) createPoster() (err error) {
-	processedOpt := getProcessOptions(rdr.Config().Opts)
+	processedOpt := getProcessedOptions(rdr.Config().Opts)
 	if processedOpt == nil && len(rdr.Config().ProcessedPath) == 0 {
 		return
 	}
@@ -199,78 +216,77 @@ func (rdr *NatsER) createPoster() (err error) {
 }

 func (rdr *NatsER) processOpts() (err error) {
-	if rdr.Config().Opts.NATSOpts.NATSSubject != nil {
-		rdr.subject = *rdr.Config().Opts.NATSOpts.NATSSubject
+	if rdr.Config().Opts.NATSOpts.Subject != nil {
+		rdr.subject = *rdr.Config().Opts.NATSOpts.Subject
 	}
 	var queueID string
-	if rdr.Config().Opts.NATSOpts.NATSQueueID != nil {
-		queueID = *rdr.Config().Opts.NATSOpts.NATSQueueID
+	if rdr.Config().Opts.NATSOpts.QueueID != nil {
+		queueID = *rdr.Config().Opts.NATSOpts.QueueID
 	}
 	rdr.queueID = utils.FirstNonEmpty(queueID, rdr.cgrCfg.GeneralCfg().NodeID)
 	var consumerName string
-	if rdr.Config().Opts.NATSOpts.NATSConsumerName != nil {
-		consumerName = *rdr.Config().Opts.NATSOpts.NATSConsumerName
+	if rdr.Config().Opts.NATSOpts.ConsumerName != nil {
+		consumerName = *rdr.Config().Opts.NATSOpts.ConsumerName
 	}
 	rdr.consumerName = utils.FirstNonEmpty(consumerName, utils.CGRateSLwr)
-	if rdr.Config().Opts.NATSOpts.NATSJetStream != nil {
-		rdr.jetStream = *rdr.Config().Opts.NATSOpts.NATSJetStream
+	if rdr.Config().Opts.NATSOpts.JetStream != nil {
+		rdr.jetStream = *rdr.Config().Opts.NATSOpts.JetStream
 	}
 	if rdr.jetStream {
-		if rdr.Config().Opts.NATSOpts.NATSJetStreamMaxWait != nil {
-			rdr.jsOpts = []nats.JSOpt{nats.MaxWait(*rdr.Config().Opts.NATSOpts.NATSJetStreamMaxWait)}
+		if rdr.Config().Opts.NATSOpts.JetStreamMaxWait != nil {
+			rdr.jsOpts = []nats.JSOpt{nats.MaxWait(*rdr.Config().Opts.NATSOpts.JetStreamMaxWait)}
 		}
 	}
-	rdr.opts, err = GetNatsOpts(rdr.Config().Opts,
+	rdr.opts, err = GetNatsOpts(rdr.Config().Opts.NATSOpts,
 		rdr.cgrCfg.GeneralCfg().NodeID,
 		rdr.cgrCfg.GeneralCfg().ConnectTimeout)
 	return
 }

-func GetNatsOpts(opts *config.EventReaderOpts, nodeID string, connTimeout time.Duration) (nop []nats.Option, err error) {
-	nop = make([]nats.Option, 0, 7)
-	nop = append(nop, nats.Name(utils.CGRateSLwr+nodeID),
+func GetNatsOpts(opts *config.NATSROpts, nodeID string, connTimeout time.Duration) (nop []nats.Option, err error) {
+	natsOpts := make([]nats.Option, 0, 7)
+	natsOpts = append(natsOpts, nats.Name(utils.CGRateSLwr+nodeID),
 		nats.Timeout(connTimeout),
 		nats.DrainTimeout(time.Second))
-	if opts.NATSOpts.NATSJWTFile != nil {
+	if opts.JWTFile != nil {
 		keys := make([]string, 0, 1)
-		if opts.NATSOpts.NATSSeedFile != nil {
-			keys = append(keys, *opts.NATSOpts.NATSSeedFile)
+		if opts.SeedFile != nil {
+			keys = append(keys, *opts.SeedFile)
 		}
-		nop = append(nop, nats.UserCredentials(*opts.NATSOpts.NATSJWTFile, keys...))
+		natsOpts = append(natsOpts, nats.UserCredentials(*opts.JWTFile, keys...))
 	}
-	if opts.NATSOpts.NATSSeedFile != nil {
-		opt, err := nats.NkeyOptionFromSeed(*opts.NATSOpts.NATSSeedFile)
+	if opts.SeedFile != nil {
+		opt, err := nats.NkeyOptionFromSeed(*opts.SeedFile)
 		if err != nil {
 			return nil, err
 		}
-		nop = append(nop, opt)
-	}
-	if opts.NATSOpts.NATSClientCertificate != nil {
-		if opts.NATSOpts.NATSClientKey == nil {
-			err = fmt.Errorf("has certificate but no key")
-			return
-		}
-		nop = append(nop, nats.ClientCert(*opts.NATSOpts.NATSClientCertificate, *opts.NATSOpts.NATSClientKey))
-	} else if opts.NATSOpts.NATSClientKey != nil {
-		err = fmt.Errorf("has key but no certificate")
-		return
+		natsOpts = append(natsOpts, opt)
 	}

-	if opts.NATSOpts.NATSCertificateAuthority != nil {
-		nop = append(nop,
+	switch {
+	case opts.ClientCertificate != nil && opts.ClientKey != nil:
+		natsOpts = append(natsOpts, nats.ClientCert(*opts.ClientCertificate, *opts.ClientKey))
+	case opts.ClientCertificate != nil:
+		return nil, fmt.Errorf("has certificate but no key")
+	case opts.ClientKey != nil:
+		return nil, fmt.Errorf("has key but no certificate")
+	}
+
+	if opts.CertificateAuthority != nil {
+		natsOpts = append(natsOpts,
 			func(o *nats.Options) error {
 				pool, err := x509.SystemCertPool()
 				if err != nil {
 					return err
 				}
-				rootPEM, err := os.ReadFile(*opts.NATSOpts.NATSCertificateAuthority)
+				rootPEM, err := os.ReadFile(*opts.CertificateAuthority)
 				if err != nil || rootPEM == nil {
 					return fmt.Errorf("nats: error loading or parsing rootCA file: %v", err)
 				}
 				ok := pool.AppendCertsFromPEM(rootPEM)
 				if !ok {
 					return fmt.Errorf("nats: failed to parse root certificate from %q",
-						*opts.NATSOpts.NATSCertificateAuthority)
+						*opts.CertificateAuthority)
 				}
 				if o.TLSConfig == nil {
 					o.TLSConfig = &tls.Config{MinVersion: tls.VersionTLS12}
@@ -280,5 +296,5 @@ func GetNatsOpts(opts *config.EventReaderOpts, nodeID string, connTimeout time.D
 				return nil
 			})
 	}
-	return
+	return natsOpts, nil
 }
--- a/ers/nats_it_test.go
+++ b/ers/nats_it_test.go
@@ -22,6 +22,7 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>
 package ers

 import (
+	"encoding/json"
 	"fmt"
 	"os"
 	"os/exec"
@@ -37,6 +38,178 @@ import (
 	"github.com/nats-io/nats.go"
 )

+func TestERsNATSIT(t *testing.T) {
+	t.Skip()
+	cfgContent := `{
+
+"general": {
+	"log_level": 7
+},
+
+"data_db": {
+	"db_type": "*internal"
+},
+
+"stor_db": {
+	"db_type": "*internal"
+},
+
+"ers": {														
+	"enabled": true,											
+	"sessions_conns":[],								
+	"readers": [
+		{
+			"id": "nats_consumer1",									
+			"type": "*nats_json_map",									
+			"source_path": "nats://127.0.0.1:4222",			
+			"processed_path": "nats://127.0.0.1:4222",		
+			"opts": {
+				"natsJetStream": true,						
+				"natsConsumerName": "cgrates_consumer",				
+				"natsSubject": "cgrates_cdrs",					
+				"natsQueueID": "queue",							
+				"natsJetStreamMaxWait": "5s",				
+
+				"natsJetStreamProcessed": true,				
+				"natsSubjectProcessed": "cgrates_cdrs_processed",		
+				"natsJetStreamMaxWaitProcessed": "5s"		
+			},
+			"flags": ["*dryrun"],										
+			"fields":[											
+				{"tag": "cdr_template", "type": "*template", "value": "cdr_template"}
+			]
+		},
+		{
+			"id": "nats_consumer2",									
+			"type": "*nats_json_map",									
+			"source_path": "nats://127.0.0.1:4222",			
+			"processed_path": "nats://127.0.0.1:4222",		
+			"opts": {
+				"natsJetStream": true,						
+				"natsConsumerName": "cgrates_consumer",				
+				"natsSubject": "cgrates_cdrs",					
+				"natsQueueID": "queue",							
+				"natsJetStreamMaxWait": "5s",				
+
+				"natsJetStreamProcessed": true,				
+				"natsSubjectProcessed": "cgrates_cdrs_processed",		
+				"natsJetStreamMaxWaitProcessed": "5s"		
+			},
+			"flags": ["*dryrun"],										
+			"fields":[											
+				{"tag": "cdr_template", "type": "*template", "value": "cdr_template"}
+			]
+		},
+		{
+			"id": "nats_consumer3",									
+			"type": "*nats_json_map",									
+			"source_path": "nats://127.0.0.1:4222",			
+			"processed_path": "nats://127.0.0.1:4222",		
+			"opts": {
+				"natsJetStream": true,						
+				"natsConsumerName": "cgrates_consumer",				
+				"natsSubject": "cgrates_cdrs",					
+				"natsQueueID": "queue",							
+				"natsJetStreamMaxWait": "5s",				
+
+				"natsJetStreamProcessed": true,				
+				"natsSubjectProcessed": "cgrates_cdrs_processed",		
+				"natsJetStreamMaxWaitProcessed": "5s"		
+			},
+			"flags": ["*dryrun"],										
+			"fields":[											
+				{"tag": "cdr_template", "type": "*template", "value": "cdr_template"}
+			]
+		},
+		{
+			"id": "nats_consumer4",									
+			"type": "*nats_json_map",									
+			"source_path": "nats://127.0.0.1:4222",			
+			"processed_path": "",		
+			"opts": {
+				"natsJetStream": true,						
+				"natsConsumerName": "cgrates_consumer4",				
+				"natsSubject": "cgrates_cdrs_processed",					
+				"natsQueueID": "",							
+				"natsJetStreamMaxWait": "5s",				
+			},
+			"flags": ["*dryrun"],										
+			"fields":[											
+				{"tag": "cdr_template", "type": "*template", "value": "cdr_template"}
+			]
+		}
+	]
+},
+	
+	
+"templates": {
+	"cdr_template": [
+		// {"tag": "Source", "path": "*cgreq.Source", "type": "*constant", "value": "ers_template_combined", "mandatory": true},
+		// {"tag": "ToR", "path": "*cgreq.ToR", "type": "*variable", "value": "~*req.2", "mandatory": true},
+		// {"tag": "OriginID", "path": "*cgreq.OriginID", "type": "*variable", "value": "~*req.3", "mandatory": true},
+		// {"tag": "RequestType", "path": "*cgreq.RequestType", "type": "*variable", "value": "~*req.4", "mandatory": true},
+		// {"tag": "Tenant", "path": "*cgreq.Tenant", "type": "*variable", "value": "~*req.6", "mandatory": true},
+		// {"tag": "Category", "path": "*cgreq.Category", "type": "*variable", "value": "~*req.7", "mandatory": true},
+		{"tag": "Account", "path": "*cgreq.Account", "type": "*variable", "value": "~*req.Account", "mandatory": true},
+		// {"tag": "Subject", "path": "*cgreq.Subject", "type": "*variable", "value": "~*req.9", "mandatory": true},
+		{"tag": "Destination", "path": "*cgreq.Destination", "type": "*variable", "value": "~*req.Destination", "mandatory": true},
+		// {"tag": "SetupTime", "path": "*cgreq.SetupTime", "type": "*variable", "value": "~*req.11", "mandatory": true},
+		// {"tag": "AnswerTime", "path": "*cgreq.AnswerTime", "type": "*variable", "value": "~*req.12", "mandatory": true},
+		// {"tag": "Usage", "path": "*cgreq.Usage", "type": "*variable", "value": "~*req.13", "mandatory": true}
+	]
+}
+	
+}`
+	cfg, cfgPath, clean, err := initTestCfg(cfgContent)
+	if err != nil {
+		t.Fatal(err)
+	}
+	defer clean()
+
+	nc, err := nats.Connect(cfg.ERsCfg().Readers[1].SourcePath)
+	if err != nil {
+		t.Fatal(err)
+	}
+	defer nc.Close()
+
+	js, err := nc.JetStream(nats.PublishAsyncMaxPending(256))
+	if err != nil {
+		t.Fatal(err)
+	}
+
+	js.AddStream(&nats.StreamConfig{
+		Name:     "CDRs",
+		Subjects: []string{"cgrates_cdrs", "cgrates_cdrs_processed"},
+	})
+
+	time.Sleep(2 * time.Second)
+
+	if _, err := engine.StopStartEngine(cfgPath, 100); err != nil {
+		t.Fatal(err)
+	}
+
+	for i := 0; i < 10; i++ {
+		cdr := map[string]any{
+			"Account":     1000 + i,
+			"Destination": 2000 + i,
+		}
+		b, _ := json.Marshal(cdr)
+		js.PublishAsync("cgrates_cdrs", b)
+	}
+	select {
+	case <-js.PublishAsyncComplete():
+	case <-time.After(5 * time.Second):
+		t.Fatal("Did not resolve in time")
+	}
+
+	// Add verification
+
+	err = engine.KillEngine(100)
+	if err != nil {
+		t.Error(err)
+	}
+}
+
 func testCheckNatsData(t *testing.T, randomCGRID, expData string, ch chan *nats.Msg) {
 	select {
 	case err := <-rdrErr:
@@ -80,7 +253,7 @@ func testCheckNatsJetStream(t *testing.T, cfg *config.CGRConfig) {
 		t.Fatal(err)
 	}

-	nop, err := GetNatsOpts(rdr.Config().Opts, "testExp", time.Second)
+	nop, err := GetNatsOpts(rdr.Config().Opts.NATSOpts, "testExp", time.Second)
 	if err != nil {
 		t.Fatal(err)
 	}
@@ -167,7 +340,7 @@ func testCheckNatsNormal(t *testing.T, cfg *config.CGRConfig) {
 		t.Fatal(err)
 	}

-	nop, err := GetNatsOpts(rdr.Config().Opts, "testExp", time.Second)
+	nop, err := GetNatsOpts(rdr.Config().Opts.NATSOpts, "testExp", time.Second)
 	if err != nil {
 		t.Fatal(err)
 	}
--- a/ers/s3.go
+++ b/ers/s3.go
@@ -195,7 +195,7 @@ func (rdr *S3ER) readLoop(scv s3Client) (err error) {
 }

 func (rdr *S3ER) createPoster() {
-	processedOpt := getProcessOptions(rdr.Config().Opts)
+	processedOpt := getProcessedOptions(rdr.Config().Opts)
 	if processedOpt == nil && len(rdr.Config().ProcessedPath) == 0 {
 		return
 	}
--- a/ers/sql.go
+++ b/ers/sql.go
@@ -301,7 +301,7 @@ func (rdr *SQLEventReader) setURL(inURL, outURL string, opts *config.EventReader
 	}

 	// outURL
-	processedOpt := getProcessOptions(opts)
+	processedOpt := getProcessedOptions(opts)
 	if processedOpt == nil {
 		if len(outURL) == 0 {
 			return
--- a/ers/sqs.go
+++ b/ers/sqs.go
@@ -219,7 +219,7 @@ func (rdr *SQSER) readLoop(scv sqsClient) (err error) {
 }

 func (rdr *SQSER) createPoster() {
-	processedOpt := getProcessOptions(rdr.Config().Opts)
+	processedOpt := getProcessedOptions(rdr.Config().Opts)
 	if processedOpt == nil && len(rdr.Config().ProcessedPath) == 0 {
 		return
 	}