Removed warnings from go staticcheck

services/analyzers.go

@@ -132,7 +132,7 @@ func (anz *AnalyzerService) Shutdown() (err error) {
 func (anz *AnalyzerService) IsRunning() bool {
 	anz.RLock()
 	defer anz.RUnlock()
-	return anz != nil && anz.anz != nil
+	return anz.anz != nil
 }
 
 // ServiceName returns the service name

services/apierv1.go

@@ -170,7 +170,7 @@ func (apiService *APIerSv1Service) Shutdown() (err error) {
 func (apiService *APIerSv1Service) IsRunning() bool {
 	apiService.RLock()
 	defer apiService.RUnlock()
-	return apiService != nil && apiService.api != nil
+	return apiService.api != nil
 }
 
 // ServiceName returns the service name

services/apierv2.go

@@ -121,7 +121,7 @@ func (api *APIerSv2Service) Shutdown() (err error) {
 func (api *APIerSv2Service) IsRunning() bool {
 	api.RLock()
 	defer api.RUnlock()
-	return api != nil && api.api != nil
+	return api.api != nil
 }
 
 // ServiceName returns the service name

services/asteriskagent.go

@@ -98,15 +98,14 @@ func (ast *AsteriskAgent) shutdown() {
 	ast.Lock()
 	close(ast.stopChan)
 	ast.smas = nil
-	ast.Unlock()
-	return // no shutdown for the momment
+	ast.Unlock() // no shutdown for the momment
 }
 
 // IsRunning returns if the service is running
 func (ast *AsteriskAgent) IsRunning() bool {
 	ast.RLock()
 	defer ast.RUnlock()
-	return ast != nil && ast.smas != nil
+	return ast.smas != nil
 }
 
 // ServiceName returns the service name

services/attributes.go

@@ -118,7 +118,7 @@ func (attrS *AttributeService) Shutdown() (err error) {
 func (attrS *AttributeService) IsRunning() bool {
 	attrS.RLock()
 	defer attrS.RUnlock()
-	return attrS != nil && attrS.attrS != nil
+	return attrS.attrS != nil
 }
 
 // ServiceName returns the service name

services/cdrs.go

@@ -138,7 +138,7 @@ func (cdrService *CDRServer) Shutdown() (err error) {
 func (cdrService *CDRServer) IsRunning() bool {
 	cdrService.RLock()
 	defer cdrService.RUnlock()
-	return cdrService != nil && cdrService.cdrS != nil
+	return cdrService.cdrS != nil
 }
 
 // ServiceName returns the service name

services/chargers.go

@@ -118,7 +118,7 @@ func (chrS *ChargerService) Shutdown() (err error) {
 func (chrS *ChargerService) IsRunning() bool {
 	chrS.RLock()
 	defer chrS.RUnlock()
-	return chrS != nil && chrS.chrS != nil
+	return chrS.chrS != nil
 }
 
 // ServiceName returns the service name

services/cores.go

@@ -112,7 +112,7 @@ func (cS *CoreService) Shutdown() (err error) {
 func (cS *CoreService) IsRunning() bool {
 	cS.RLock()
 	defer cS.RUnlock()
-	return cS != nil && cS.cS != nil
+	return cS.cS != nil
 }
 
 // ServiceName returns the service name

services/datadb.go

@@ -117,7 +117,7 @@ func (db *DataDBService) Shutdown() (err error) {
 func (db *DataDBService) IsRunning() bool {
 	db.RLock()
 	defer db.RUnlock()
-	return db != nil && db.dm != nil && db.dm.DataDB() != nil
+	return db.dm != nil && db.dm.DataDB() != nil
 }
 
 // ServiceName returns the service name

services/diameteragent.go

@@ -122,7 +122,7 @@ func (da *DiameterAgent) Shutdown() (err error) {
 func (da *DiameterAgent) IsRunning() bool {
 	da.RLock()
 	defer da.RUnlock()
-	return da != nil && da.da != nil
+	return da.da != nil
 }
 
 // ServiceName returns the service name

services/dispatchers.go

@@ -122,7 +122,7 @@ func (dspS *DispatcherService) Shutdown() (err error) {
 func (dspS *DispatcherService) IsRunning() bool {
 	dspS.RLock()
 	defer dspS.RUnlock()
-	return dspS != nil && dspS.dspS != nil
+	return dspS.dspS != nil
 }
 
 // ServiceName returns the service name

services/ees.go

@@ -79,7 +79,7 @@ func (es *EventExporterService) ShouldRun() (should bool) {
 func (es *EventExporterService) IsRunning() bool {
 	es.RLock()
 	defer es.RUnlock()
-	return es != nil && es.eeS != nil
+	return es.eeS != nil
 }
 
 // Reload handles the change of config

services/ers.go

@@ -109,7 +109,7 @@ func (erS *EventReaderService) Shutdown() (err error) {
 func (erS *EventReaderService) IsRunning() bool {
 	erS.RLock()
 	defer erS.RUnlock()
-	return erS != nil && erS.ers != nil
+	return erS.ers != nil
 }
 
 // ServiceName returns the service name

services/freeswitchagent.go

@@ -111,7 +111,7 @@ func (fS *FreeswitchAgent) Shutdown() (err error) {
 func (fS *FreeswitchAgent) IsRunning() bool {
 	fS.RLock()
 	defer fS.RUnlock()
-	return fS != nil && fS.fS != nil
+	return fS.fS != nil
 }
 
 // ServiceName returns the service name

services/httpagent.go

@@ -96,7 +96,7 @@ func (ha *HTTPAgent) Shutdown() (err error) {
 func (ha *HTTPAgent) IsRunning() bool {
 	ha.RLock()
 	defer ha.RUnlock()
-	return ha != nil && ha.started
+	return ha.started
 }
 
 // ServiceName returns the service name

services/kamailioagent.go

@@ -117,7 +117,7 @@ func (kam *KamailioAgent) Shutdown() (err error) {
 func (kam *KamailioAgent) IsRunning() bool {
 	kam.RLock()
 	defer kam.RUnlock()
-	return kam != nil && kam.kam != nil
+	return kam.kam != nil
 }
 
 // ServiceName returns the service name

services/loaders.go

@@ -136,7 +136,7 @@ func (ldrs *LoaderService) Shutdown() (err error) {
 func (ldrs *LoaderService) IsRunning() bool {
 	ldrs.RLock()
 	defer ldrs.RUnlock()
-	return ldrs != nil && ldrs.ldrs != nil && ldrs.ldrs.Enabled()
+	return ldrs.ldrs != nil && ldrs.ldrs.Enabled()
 }
 
 // ServiceName returns the service name

services/radiusagent.go

@@ -123,7 +123,7 @@ func (rad *RadiusAgent) shutdown() {
 func (rad *RadiusAgent) IsRunning() bool {
 	rad.RLock()
 	defer rad.RUnlock()
-	return rad != nil && rad.rad != nil
+	return rad.rad != nil
 }
 
 // ServiceName returns the service name

services/rals.go

@@ -122,7 +122,7 @@ func (rals *RalService) Shutdown() (err error) {
 func (rals *RalService) IsRunning() bool {
 	rals.RLock()
 	defer rals.RUnlock()
-	return rals != nil && rals.rals != nil
+	return rals.rals != nil
 }
 
 // ServiceName returns the service name

services/registrarc.go

@@ -93,7 +93,7 @@ func (dspS *RegistrarCService) Shutdown() (err error) {
 func (dspS *RegistrarCService) IsRunning() bool {
 	dspS.RLock()
 	defer dspS.RUnlock()
-	return dspS != nil && dspS.dspS != nil
+	return dspS.dspS != nil
 }
 
 // ServiceName returns the service name

services/resources.go

@@ -122,7 +122,7 @@ func (reS *ResourceService) Shutdown() (err error) {
 func (reS *ResourceService) IsRunning() bool {
 	reS.RLock()
 	defer reS.RUnlock()
-	return reS != nil && reS.reS != nil
+	return reS.reS != nil
 }
 
 // ServiceName returns the service name

services/routes.go

@@ -117,7 +117,7 @@ func (routeS *RouteService) Shutdown() (err error) {
 func (routeS *RouteService) IsRunning() bool {
 	routeS.RLock()
 	defer routeS.RUnlock()
-	return routeS != nil && routeS.routeS != nil
+	return routeS.routeS != nil
 }
 
 // ServiceName returns the service name

services/schedulers.go

@@ -123,7 +123,7 @@ func (schS *SchedulerService) Shutdown() (err error) {
 func (schS *SchedulerService) IsRunning() bool {
 	schS.RLock()
 	defer schS.RUnlock()
-	return schS != nil && schS.schS != nil
+	return schS.schS != nil
 }
 
 // ServiceName returns the service name

services/sessions.go

@@ -163,7 +163,7 @@ func (smg *SessionService) Shutdown() (err error) {
 func (smg *SessionService) IsRunning() bool {
 	smg.RLock()
 	defer smg.RUnlock()
-	return smg != nil && smg.sm != nil
+	return smg.sm != nil
 }
 
 // ServiceName returns the service name

services/sipagent.go

@@ -115,7 +115,7 @@ func (sip *SIPAgent) Shutdown() (err error) {
 func (sip *SIPAgent) IsRunning() bool {
 	sip.RLock()
 	defer sip.RUnlock()
-	return sip != nil && sip.sip != nil
+	return sip.sip != nil
 }
 
 // ServiceName returns the service name

services/stats.go

@@ -126,7 +126,7 @@ func (sts *StatService) Shutdown() (err error) {
 func (sts *StatService) IsRunning() bool {
 	sts.RLock()
 	defer sts.RUnlock()
-	return sts != nil && sts.sts != nil
+	return sts.sts != nil
 }
 
 // ServiceName returns the service name

services/thresholds.go

@@ -122,7 +122,7 @@ func (thrs *ThresholdService) Shutdown() (err error) {
 func (thrs *ThresholdService) IsRunning() bool {
 	thrs.RLock()
 	defer thrs.RUnlock()
-	return thrs != nil && thrs.thrs != nil
+	return thrs.thrs != nil
 }
 
 // ServiceName returns the service name