Removed warnings from go staticcheck

utils/coreutils_test.go

@@ -28,7 +28,6 @@ import (
 
 	"golang.org/x/crypto/bcrypt"
 
-	"github.com/cgrates/birpc"
 	"github.com/cgrates/rpcclient"
 )
 
@@ -1779,32 +1778,6 @@ func TestMonthlyEstimated(t *testing.T) {
 	}
 }
 
-type server struct{}
-
-type client struct{}
-
-func (c client) Call(serviceMethod string, args any, reply any) (err error) {
-	err = ErrExists
-	return
-}
-
-func (srv *server) BiRPCv1ValidMethod(cl birpc.ClientConnector, args any, req any) error {
-	return nil
-}
-
-func (srv *server) BiRPCv1MultipleParams(cl birpc.ClientConnector, args any, req any) (int, error) {
-	return 1, nil
-}
-
-func (srv *server) BiRPCv1NoErrorReturn(cl birpc.ClientConnector, args any, req any) int {
-	return 1
-}
-
-func (srv *server) BiRPCv1FinalError(cl birpc.ClientConnector, args any, req any) (err error) {
-	err = ErrExists
-	return
-}
-
 func TestCoreUtilsGenerateDBItemOpts(t *testing.T) {
 	apiKey := "testKey1"
 	routeID := "testKey2"

utils/dynamicweight.go

@@ -78,9 +78,7 @@ func (dW *DynamicWeight) Clone() (dinWeight *DynamicWeight) {
 	}
 	if dW.FilterIDs != nil {
 		dinWeight.FilterIDs = make([]string, len(dW.FilterIDs))
-		for i, value := range dW.FilterIDs {
-			dinWeight.FilterIDs[i] = value
-		}
+		copy(dinWeight.FilterIDs, dW.FilterIDs)
 	}
 	return dinWeight
 }

utils/map.go

@@ -86,9 +86,7 @@ func (sm StringMap) Slice() []string {
 }
 
 func (sm StringMap) IsEmpty() bool {
-	return sm == nil ||
-		len(sm) == 0 ||
-		sm[MetaAny]
+	return len(sm) == 0 || sm[MetaAny]
 }
 
 func StringMapFromSlice(s []string) StringMap {
@@ -273,7 +271,7 @@ func (fWp FlagsWithParams) GetBool(key string) (b bool) {
 	if v, b = fWp[key]; !b {
 		return // not present means false
 	}
-	if v == nil || len(v) == 0 {
+	if len(v) == 0 {
 		return true // empty map
 	}
 	return v.Has(TrueStr) || !v.Has(FalseStr)