From ea9b6ae83d942cfdf73ee0cad4cafdbc177a33dc Mon Sep 17 00:00:00 2001 From: ionutboangiu Date: Fri, 22 Mar 2024 14:41:17 -0400 Subject: [PATCH] Remove unused parameters from fs reload func --- services/freeswitchagent.go | 9 +++++---- services/freeswitchagent_it_test.go | 5 +---- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/services/freeswitchagent.go b/services/freeswitchagent.go index 59c1b4d22..f4ba7db15 100644 --- a/services/freeswitchagent.go +++ b/services/freeswitchagent.go @@ -65,7 +65,9 @@ func (fS *FreeswitchAgent) Start() error { var err error fS.fS, err = agents.NewFSsessions(fS.cfg.FsAgentCfg(), fS.cfg.GeneralCfg().DefaultTimezone, fS.connMgr) if err != nil { - utils.Logger.Err(fmt.Sprintf("<%s> failed to initialize agent, error: %s", utils.FreeSWITCHAgent, err)) + utils.Logger.Err(fmt.Sprintf( + "<%s> failed to initialize agent, error: %v", + utils.FreeSWITCHAgent, err)) return err } @@ -86,16 +88,15 @@ func (fS *FreeswitchAgent) Reload() (err error) { return } fS.fS.Reload() - go fS.reload(fS.fS) + go fS.reload() return } -func (fS *FreeswitchAgent) reload(f *agents.FSsessions) (err error) { +func (fS *FreeswitchAgent) reload() { if err := fS.fS.Connect(); err != nil { utils.Logger.Err(fmt.Sprintf("<%s> error: %s!", utils.FreeSWITCHAgent, err)) fS.shdChan.CloseOnce() // stop the engine here } - return } // Shutdown stops the service diff --git a/services/freeswitchagent_it_test.go b/services/freeswitchagent_it_test.go index f862f3a0e..033b527a5 100644 --- a/services/freeswitchagent_it_test.go +++ b/services/freeswitchagent_it_test.go @@ -209,10 +209,7 @@ func TestFreeSwitchAgentReload4(t *testing.T) { if err != nil { t.Fatal(err) } - err = srv.(*FreeswitchAgent).reload(srv.(*FreeswitchAgent).fS) - if err != nil { - t.Fatalf("\nExpected <%+v>, \nReceived <%+v>", nil, err) - } + srv.(*FreeswitchAgent).reload() } func TestFreeSwitchAgentReload5(t *testing.T) {