From f26a0c2d0b8515fd0cfeabe32d74e1b1e84fb9f0 Mon Sep 17 00:00:00 2001 From: ionutboangiu Date: Wed, 25 Sep 2024 12:33:07 +0300 Subject: [PATCH] Reduce client connection attempts to test engine status 200 -> 16 Previously, considering the fibonacci back off strategy, if engine failed to start it would have tried to attempt connections for 2.862799e+33 years. Now, the amount of attempts is 16, equivalent to around 2 and a half seconds. Should be more than enough, considering that usually 6-7 attempts are enough. --- apis/cores_it_test.go | 4 ++-- engine/libtest.go | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/apis/cores_it_test.go b/apis/cores_it_test.go index 0d95229d8..63ee9236a 100644 --- a/apis/cores_it_test.go +++ b/apis/cores_it_test.go @@ -128,7 +128,7 @@ func testCoreItStartEngineByExecWithCPUProfiling(t *testing.T) { } fib := utils.FibDuration(time.Millisecond, 0) var connected bool - for i := 0; i < 200; i++ { + for i := 0; i < 16; i++ { time.Sleep(fib()) if _, err := jsonrpc.Dial(utils.TCP, coreSCfg.ListenCfg().RPCJSONListen); err != nil { t.Log(err) @@ -184,7 +184,7 @@ func testCoreItStartEngineByExecWIthMemProfiling(t *testing.T) { } fib := utils.FibDuration(time.Millisecond, 0) var connected bool - for i := 0; i < 200; i++ { + for i := 0; i < 16; i++ { time.Sleep(fib()) if _, err := jsonrpc.Dial(utils.TCP, coreSCfg.ListenCfg().RPCJSONListen); err != nil { t.Log(err) diff --git a/engine/libtest.go b/engine/libtest.go index f5a821b62..ca94b8b78 100644 --- a/engine/libtest.go +++ b/engine/libtest.go @@ -119,7 +119,7 @@ func StartEngine(cfgPath string, waitEngine int) (*exec.Cmd, error) { } fib := utils.FibDuration(time.Millisecond, 0) var connected bool - for i := 0; i < 200; i++ { + for i := 0; i < 16; i++ { time.Sleep(fib()) if _, err := jsonrpc.Dial(utils.TCP, cfg.ListenCfg().RPCJSONListen); err != nil { utils.Logger.Warning(fmt.Sprintf("Error <%s> when opening test connection to: <%s>", @@ -147,7 +147,7 @@ func StartEngineWithContext(ctx context.Context, cfgPath string, waitEngine int) return } fib := utils.FibDuration(time.Millisecond, 0) - for i := 0; i < 200; i++ { + for i := 0; i < 16; i++ { time.Sleep(fib()) if _, err = jsonrpc.Dial(utils.TCP, cfg.ListenCfg().RPCJSONListen); err != nil { continue