mirror of
https://github.com/cgrates/cgrates.git
synced 2026-02-21 23:28:44 +05:00
c7dbcaea03
CPU profiling changes:
cgr-engine.go:
- use filepath.Join instead of path.Join
- handle *CoreService.StopCPUProfiling error inside deferred function
- same with the error from *os.File.Close()
cores/core.go:
- StartCPUProfile now returns an *os.File (as opposed to an io.WriteCloser),
because os.File.Stat is used beforehand to check if a handler of the file is
already active and confirm the status of profiling. Asserting the type would
have worked as well.
- handle pprof.StartCPUProfile error and ensure file is closed before returning
- log file close error as a warning if it occurs
- return missing mandatory error with correct path field name ('DirPath')
- no need to check if fileCPU is nil for profiling status
- pprof.StartCPUProfiling will return an error if profiling is already started
- os.File.Close() will return ErrClosed if profiling is already stopped
- differentiate between calling StopCPUProfiling when profiling hasn't started
and when it was already stopped by returning appropriate errors
Memory profiling changes:
- merge StopChanMemProf with StopMemoryProfiling
- remove fileMEM and stopMemProf from struct and constructors
- add separate mutex for memory profiling, ensure thread safety
- handle all significant errors
- log error if StopMemoryProfiling fails during CoreS Shutdown
- ignore errors if profiling inactive in Shutdown and deferred Stop
- move validations inside V1 functions
- return error if StartMemoryProfiling already started
- return error if StopMemoryProfiling already stopped or never started
- close profiling loop on error, not the cgr-engine
- StopMemoryProfiling closes channel and profiling loop writes final profile
- rename Path to DirPath for mandatory field error
- rename memprof_nrfiles flag to memprof_maxfiles
- increase default memprof_interval
- consider MaxFiles <= 0 as unlimited
- move memory profiling logic after starting services
- use CoreService Start/StopMemoryProfiling in main
- remove final memory profile block (created by deferred Stop)
- convert MemProfiling to method on CoreService and rename to profileMemory
- use Ticker for recurrent actions instead of Timer
- compute mem_final.prof full path in StartMemoryProfiling
- suffix profile files with current time instead of numbers
- update dispatcher methods after changes
- move MemoryPrf from utils to cores, rename to MemoryProfilingParams
- add logs for starting/stopping profiling
- added the possibility to disable timestamps in the memory profile file names
and use increments of 1 instead.
Other changes:
- improved integration tests for flags (now table tests)
- improved profiling integration tests
103 lines
3.5 KiB
Go
103 lines
3.5 KiB
Go
/*
|
|
Real-time Online/Offline Charging System (OCS) for Telecom & ISP environments
|
|
Copyright (C) ITsysCOM GmbH
|
|
|
|
This program is free software: you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation, either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>
|
|
*/
|
|
|
|
package cores
|
|
|
|
import (
|
|
"reflect"
|
|
"runtime"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/cgrates/cgrates/config"
|
|
"github.com/cgrates/cgrates/engine"
|
|
"github.com/cgrates/cgrates/utils"
|
|
)
|
|
|
|
func TestNewCoreService(t *testing.T) {
|
|
cfgDflt := config.NewDefaultCGRConfig()
|
|
cfgDflt.CoreSCfg().CapsStatsInterval = time.Second
|
|
stopchan := make(chan struct{}, 1)
|
|
caps := engine.NewCaps(1, utils.MetaBusy)
|
|
sts := engine.NewCapsStats(cfgDflt.CoreSCfg().CapsStatsInterval, caps, stopchan)
|
|
expected := &CoreS{
|
|
cfg: cfgDflt,
|
|
CapsStats: sts,
|
|
caps: caps,
|
|
}
|
|
rcv := NewCoreService(cfgDflt, caps, nil, stopchan, nil, nil)
|
|
if !reflect.DeepEqual(expected, rcv) {
|
|
t.Errorf("Expected %+v, received %+v", expected, rcv)
|
|
}
|
|
//shut down the service
|
|
rcv.shtDw = func() {}
|
|
rcv.Shutdown()
|
|
rcv.ShutdownEngine()
|
|
}
|
|
|
|
func TestCoreServiceStatus(t *testing.T) {
|
|
cfg := config.NewDefaultCGRConfig()
|
|
cfg.CoreSCfg().CapsStatsInterval = 1
|
|
cores := NewCoreService(cfg, engine.NewCaps(1, utils.MetaBusy), nil, nil, nil, func() {})
|
|
|
|
var reply map[string]any
|
|
cfgVrs, err := utils.GetCGRVersion()
|
|
if err != nil {
|
|
t.Error(err)
|
|
}
|
|
|
|
expected := map[string]any{
|
|
utils.GoVersion: runtime.Version(),
|
|
utils.RunningSince: "TIME_CHANGED",
|
|
utils.VersionName: cfgVrs,
|
|
utils.ActiveGoroutines: runtime.NumGoroutine(),
|
|
utils.MemoryUsage: "CHANGED_MEMORY_USAGE",
|
|
utils.NodeID: cfg.GeneralCfg().NodeID,
|
|
}
|
|
if err := cores.V1Status(nil, nil, &reply); err != nil {
|
|
t.Error(err)
|
|
} else {
|
|
reply[utils.RunningSince] = "TIME_CHANGED"
|
|
reply[utils.MemoryUsage] = "CHANGED_MEMORY_USAGE"
|
|
}
|
|
|
|
if !reflect.DeepEqual(expected[utils.GoVersion], reply[utils.GoVersion]) {
|
|
t.Errorf("Expected %+v, received %+v", utils.ToJSON(expected[utils.GoVersion]), utils.ToJSON(reply[utils.GoVersion]))
|
|
}
|
|
if !reflect.DeepEqual(expected[utils.RunningSince], reply[utils.RunningSince]) {
|
|
t.Errorf("Expected %+v, received %+v", utils.ToJSON(expected[utils.RunningSince]), utils.ToJSON(reply[utils.RunningSince]))
|
|
}
|
|
if !reflect.DeepEqual(expected[utils.VersionName], reply[utils.VersionName]) {
|
|
t.Errorf("Expected %+v, received %+v", utils.ToJSON(expected[utils.VersionName]), utils.ToJSON(reply[utils.VersionName]))
|
|
}
|
|
if !reflect.DeepEqual(expected[utils.MemoryUsage], reply[utils.MemoryUsage]) {
|
|
t.Errorf("Expected %+v, received %+v", utils.ToJSON(expected[utils.MemoryUsage]), utils.ToJSON(reply[utils.MemoryUsage]))
|
|
}
|
|
if !reflect.DeepEqual(expected[utils.NodeID], reply[utils.NodeID]) {
|
|
t.Errorf("Expected %+v, received %+v", utils.ToJSON(expected[utils.NodeID]), utils.ToJSON(reply[utils.NodeID]))
|
|
}
|
|
utils.GitCommitDate = "wrong format"
|
|
utils.GitCommitHash = "73014DAA0C1D7EDCB532D5FE600B8A20D588CDF8"
|
|
if err := cores.V1Status(nil, nil, &reply); err != nil {
|
|
t.Error(err)
|
|
}
|
|
|
|
utils.GitCommitDate = ""
|
|
utils.GitCommitHash = ""
|
|
}
|