mirror of
https://github.com/cgrates/cgrates.git
synced 2026-02-14 12:49:54 +05:00
c7dbcaea03
CPU profiling changes:
cgr-engine.go:
- use filepath.Join instead of path.Join
- handle *CoreService.StopCPUProfiling error inside deferred function
- same with the error from *os.File.Close()
cores/core.go:
- StartCPUProfile now returns an *os.File (as opposed to an io.WriteCloser),
because os.File.Stat is used beforehand to check if a handler of the file is
already active and confirm the status of profiling. Asserting the type would
have worked as well.
- handle pprof.StartCPUProfile error and ensure file is closed before returning
- log file close error as a warning if it occurs
- return missing mandatory error with correct path field name ('DirPath')
- no need to check if fileCPU is nil for profiling status
- pprof.StartCPUProfiling will return an error if profiling is already started
- os.File.Close() will return ErrClosed if profiling is already stopped
- differentiate between calling StopCPUProfiling when profiling hasn't started
and when it was already stopped by returning appropriate errors
Memory profiling changes:
- merge StopChanMemProf with StopMemoryProfiling
- remove fileMEM and stopMemProf from struct and constructors
- add separate mutex for memory profiling, ensure thread safety
- handle all significant errors
- log error if StopMemoryProfiling fails during CoreS Shutdown
- ignore errors if profiling inactive in Shutdown and deferred Stop
- move validations inside V1 functions
- return error if StartMemoryProfiling already started
- return error if StopMemoryProfiling already stopped or never started
- close profiling loop on error, not the cgr-engine
- StopMemoryProfiling closes channel and profiling loop writes final profile
- rename Path to DirPath for mandatory field error
- rename memprof_nrfiles flag to memprof_maxfiles
- increase default memprof_interval
- consider MaxFiles <= 0 as unlimited
- move memory profiling logic after starting services
- use CoreService Start/StopMemoryProfiling in main
- remove final memory profile block (created by deferred Stop)
- convert MemProfiling to method on CoreService and rename to profileMemory
- use Ticker for recurrent actions instead of Timer
- compute mem_final.prof full path in StartMemoryProfiling
- suffix profile files with current time instead of numbers
- update dispatcher methods after changes
- move MemoryPrf from utils to cores, rename to MemoryProfilingParams
- add logs for starting/stopping profiling
- added the possibility to disable timestamps in the memory profile file names
and use increments of 1 instead.
Other changes:
- improved integration tests for flags (now table tests)
- improved profiling integration tests
75 lines
2.4 KiB
Go
75 lines
2.4 KiB
Go
/*
|
|
Real-time Online/Offline Charging System (OCS) for Telecom & ISP environments
|
|
Copyright (C) ITsysCOM GmbH
|
|
|
|
This program is free software: you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation, either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>
|
|
*/
|
|
package services
|
|
|
|
import (
|
|
"reflect"
|
|
"sync"
|
|
"testing"
|
|
|
|
"github.com/cgrates/birpc"
|
|
"github.com/cgrates/cgrates/config"
|
|
"github.com/cgrates/cgrates/cores"
|
|
"github.com/cgrates/cgrates/engine"
|
|
"github.com/cgrates/cgrates/utils"
|
|
)
|
|
|
|
// TestCoreSCoverage for cover testing
|
|
func TestCoreSCoverage(t *testing.T) {
|
|
cfg := config.NewDefaultCGRConfig()
|
|
caps := engine.NewCaps(1, "test_caps")
|
|
server := cores.NewServer(nil)
|
|
internalCoreSChan := make(chan birpc.ClientConnector, 1)
|
|
filterSChan := make(chan *engine.FilterS, 1)
|
|
filterSChan <- nil
|
|
srvDep := map[string]*sync.WaitGroup{utils.DataDB: new(sync.WaitGroup)}
|
|
anz := NewAnalyzerService(cfg, server, filterSChan, make(chan birpc.ClientConnector, 1), srvDep)
|
|
srv := NewCoreService(cfg, caps, server, internalCoreSChan, anz, nil, nil, srvDep)
|
|
if srv == nil {
|
|
t.Errorf("\nExpecting <nil>,\n Received <%+v>", utils.ToJSON(srv))
|
|
}
|
|
if srv.IsRunning() {
|
|
t.Errorf("Expected service to be down")
|
|
}
|
|
srv.cS = &cores.CoreS{}
|
|
if !srv.IsRunning() {
|
|
t.Errorf("Expected service to be running")
|
|
}
|
|
serviceName := srv.ServiceName()
|
|
if !reflect.DeepEqual(serviceName, utils.CoreS) {
|
|
t.Errorf("\nExpecting <%+v>,\n Received <%+v>", utils.CoreS, serviceName)
|
|
}
|
|
shouldRun := srv.ShouldRun()
|
|
if !reflect.DeepEqual(shouldRun, true) {
|
|
t.Errorf("\nExpecting <true>,\n Received <%+v>", shouldRun)
|
|
}
|
|
//populates connChan with something in order to call the shutdown function
|
|
srv.connChan <- &testMockClients{}
|
|
srv.stopChan = make(chan struct{})
|
|
// srv.csCh = make(chan *cores.CoreService, 1)
|
|
srv.csCh <- nil
|
|
getShut := srv.Shutdown()
|
|
if getShut != nil {
|
|
t.Errorf("\nExpecting not <nil>,\n Received <%+v>", getShut)
|
|
}
|
|
if srv.IsRunning() {
|
|
t.Errorf("Expected service to be down")
|
|
}
|
|
|
|
}
|