uppal/cgrates
1
0
Fork 1
mirror of https://github.com/cgrates/cgrates.git synced 2026-02-11 18:16:24 +05:00
Code Issues Packages Projects Releases Wiki Activity

optimize batch index removal

Browse Source
This commit is contained in:
ionutboangiu
2025-09-22 20:46:22 +03:00
committed by Dan Christian Bogos
parent 102abf559b
commit 52aa161331
2 changed files with 25 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
engine/datamanager.go
View File

@@ -3840,6 +3840,9 @@ func (dm *DataManager) SetIndexes(idxItmType, tntCtx string,
if dm == nil {
return utils.ErrNoDatabaseConn
}
/*
TODO: Check if there's any downside to returning early when len(indexes) == 0.
*/
if err = dm.DataDB().SetIndexesDrv(idxItmType, tntCtx,
indexes, commit, transactionID); err != nil {
return

38
engine/libindex.go
View File

@@ -801,31 +801,37 @@ func UpdateFilterIndex(dm *DataManager, oldFlt, newFlt *Filter) (err error) {
// removeFilterIndexesForFilter removes itemIDs from the specified filter index keys.
// Used to update the index map when a filter is modified.
func removeFilterIndexesForFilter(dm *DataManager, idxItmType, tnt string,
removeIndexKeys []string, itemIDs utils.StringSet) error {
func removeFilterIndexesForFilter(dm *DataManager, itemType, tnt string,
removeIndexKeys []string, removeItemIDs utils.StringSet) error {
if len(removeIndexKeys) == 0 {
return nil // no indexes to remove
}
refID := guardian.Guardian.GuardIDs(utils.EmptyString,
config.CgrConfig().GeneralCfg().LockingTimeout, idxItmType+tnt)
config.CgrConfig().GeneralCfg().LockingTimeout, itemType+tnt)
defer guardian.Guardian.UnguardIDs(refID)
for _, idxKey := range removeIndexKeys {
fltrIdx, err := dm.GetIndexes(idxItmType, tnt,
true, false, idxKey)
if err != nil {
if err != utils.ErrNotFound {
return err
}
continue
indexes, err := dm.GetIndexes(itemType, tnt, true, false, removeIndexKeys...)
if err != nil {
if err == utils.ErrNotFound {
return nil // nothing to remove
}
for itemID := range itemIDs {
fltrIdx[idxKey].Remove(itemID)
return err
}
updatedIndexes := make(map[string]utils.StringSet)
for _, key := range removeIndexKeys {
itemIDs, exists := indexes[key]
if !exists {
continue // skip missing indexes
}
if err := dm.SetIndexes(idxItmType, tnt, fltrIdx, true,
utils.NonTransactional); err != nil {
return err
for itemID := range removeItemIDs {
itemIDs.Remove(itemID)
}
updatedIndexes[key] = itemIDs // only add modified indexes
}
if err := dm.SetIndexes(itemType, tnt, updatedIndexes, true, utils.NonTransactional); err != nil {
return err
}
return nil
}