fixed go vet warnings

.github/workflows/build.yaml

@@ -40,7 +40,6 @@ jobs:
         run: gofmt -s -w . && git diff --exit-code
 
       - name: Go Vet
-        continue-on-error: true # option will soon be removed
         run: go vet ./...
 
       - name: Go Tidy

agents/librad.go

@@ -54,16 +54,6 @@ func radComposedFieldValue(pkt *radigo.Packet,
 			outVal += out
 			continue
 		}
-		for _, avp := range pkt.AttributesWithName(
-			attrVendorFromPath(rsrTpl.Rules)) {
-			if parsed, err := rsrTpl.ParseValue(avp.GetStringValue()); err != nil {
-				utils.Logger.Warning(
-					fmt.Sprintf("<%s> %s",
-						utils.RadiusAgent, err.Error()))
-			} else {
-				outVal += parsed
-			}
-		}
 	}
 	return outVal
 }

engine/caches_test.go

@@ -477,9 +477,9 @@ func TestCacheSV1ReloadCacheErrors(t *testing.T) {
 		{
 			name: "FlushAll",
 			args: args{attrs: utils.AttrReloadCacheWithArgDispatcher{
-				&utils.ArgDispatcher{},
-				utils.TenantArg{},
-				utils.AttrReloadCache{
+				ArgDispatcher: &utils.ArgDispatcher{},
+				TenantArg:     utils.TenantArg{},
+				AttrReloadCache: utils.AttrReloadCache{
 					FlushAll: true,
 				},
 			}, reply: &str},
@@ -488,10 +488,10 @@ func TestCacheSV1ReloadCacheErrors(t *testing.T) {
 		{
 			name: "Reload destination error",
 			args: args{attrs: utils.AttrReloadCacheWithArgDispatcher{
-				&utils.ArgDispatcher{},
-				utils.TenantArg{},
-				utils.AttrReloadCache{
-					utils.ArgsCache{
+				ArgDispatcher: &utils.ArgDispatcher{},
+				TenantArg:     utils.TenantArg{},
+				AttrReloadCache: utils.AttrReloadCache{
+					ArgsCache: utils.ArgsCache{
 						DestinationIDs:        slc,
 						ReverseDestinationIDs: slc,
 						RatingPlanIDs:         slc,
@@ -515,7 +515,7 @@ func TestCacheSV1ReloadCacheErrors(t *testing.T) {
 						DispatcherHostIDs:     slc,
 						DispatcherRoutesIDs:   slc,
 					},
-					false,
+					FlushAll: false,
 				},
 			}, reply: &str},
 			err: "err",
@@ -547,9 +547,9 @@ func TestCacheSV1LoadCache(t *testing.T) {
 	}
 
 	err := chS.V1LoadCache(utils.AttrReloadCacheWithArgDispatcher{
-		&utils.ArgDispatcher{},
-		utils.TenantArg{},
-		utils.AttrReloadCache{
+		ArgDispatcher: &utils.ArgDispatcher{},
+		TenantArg:     utils.TenantArg{},
+		AttrReloadCache: utils.AttrReloadCache{
 			FlushAll: true,
 		},
 	}, &str)
@@ -571,9 +571,9 @@ func TestCacheSV1FlushCacheFlushAll(t *testing.T) {
 	}
 
 	err := chS.V1FlushCache(utils.AttrReloadCacheWithArgDispatcher{
-		&utils.ArgDispatcher{},
-		utils.TenantArg{},
-		utils.AttrReloadCache{
+		ArgDispatcher: &utils.ArgDispatcher{},
+		TenantArg:     utils.TenantArg{},
+		AttrReloadCache: utils.AttrReloadCache{
 			FlushAll: true,
 		},
 	}, &str)

engine/safevent.go

@@ -119,7 +119,7 @@ func (se *SafEvent) GetString(fldName string) (out string, err error) {
 	return
 }
 
-func (se SafEvent) GetTInt64(fldName string) (out int64, err error) {
+func (se *SafEvent) GetTInt64(fldName string) (out int64, err error) {
 	se.RLock()
 	out, err = se.Me.GetTInt64(fldName)
 	se.RUnlock()

migrator/storage_redis.go

@@ -566,8 +566,6 @@ func (v1rs *redisMigrator) remV1Alias(key string) (err error) {
 		}
 	}
 	return
-
-	return v1rs.rds.Cmd("DEL", key).Err
 }
 
 // User methods

scheduler/scheduler.go

@@ -58,10 +58,11 @@ func NewScheduler(dm *engine.DataManager, cfg *config.CGRConfig,
 }
 
 func (s *Scheduler) updateActStats(act *engine.Action, isFailed bool) {
-	mux := s.aSMux
+	var mux *sync.RWMutex
+	mux = &s.aSMux
 	statsMp := s.actSuccessStats
 	if isFailed {
-		mux = s.aFMux
+		mux = &s.aFMux
 		statsMp = s.actFailedStats
 	}
 	now := time.Now()

utils/server.go

@@ -374,7 +374,7 @@ func (r *rpcRequest) Call() io.Reader {
 }
 
 func loadTLSConfig(serverCrt, serverKey, caCert string, serverPolicy int,
-	serverName string) (config tls.Config, err error) {
+	serverName string) (config *tls.Config, err error) {
 	cert, err := tls.LoadX509KeyPair(serverCrt, serverKey)
 	if err != nil {
 		log.Fatalf("Error: %s when load server keys", err)
@@ -401,7 +401,7 @@ func loadTLSConfig(serverCrt, serverKey, caCert string, serverPolicy int,
 		}
 	}
 
-	config = tls.Config{
+	config = &tls.Config{
 		Certificates: []tls.Certificate{cert},
 		ClientAuth:   tls.ClientAuthType(serverPolicy),
 		ClientCAs:    rootCAs,
@@ -424,7 +424,7 @@ func (s *Server) ServeGOBTLS(addr, serverCrt, serverKey, caCert string,
 	if err != nil {
 		return
 	}
-	listener, err := tls.Listen(TCP, addr, &config)
+	listener, err := tls.Listen(TCP, addr, config)
 	if err != nil {
 		log.Printf("Error: %s when listening", err)
 		exitChan <- true
@@ -467,7 +467,7 @@ func (s *Server) ServeJSONTLS(addr, serverCrt, serverKey, caCert string,
 	if err != nil {
 		return
 	}
-	listener, err := tls.Listen(TCP, addr, &config)
+	listener, err := tls.Listen(TCP, addr, config)
 	if err != nil {
 		log.Printf("Error: %s when listening", err)
 		exitChan <- true
@@ -554,7 +554,7 @@ func (s *Server) ServeHTTPTLS(addr, serverCrt, serverKey, caCert string, serverP
 	httpSrv := http.Server{
 		Addr:      addr,
 		Handler:   s.httpsMux,
-		TLSConfig: &config,
+		TLSConfig: config,
 	}
 	Logger.Info(fmt.Sprintf("<HTTPS> start listening at <%s>", addr))
 	if err := httpSrv.ListenAndServeTLS(serverCrt, serverKey); err != nil {