Remove redundant http_pprof cgr-engine flag

runtime profiling is now configurable within the http cfg section and
is enabled by default

cmd/cgr-engine/cgr-engine.go

@@ -54,7 +54,6 @@ var (
 	version           = cgrEngineFlags.Bool(utils.VersionCgr, false, "Print application version and exit")
 	printConfig       = cgrEngineFlags.Bool(utils.PrintCfgCgr, false, "Print configuration object in JSON format")
 	pidFile           = cgrEngineFlags.String(utils.PidCgr, utils.EmptyString, "Path to write the PID file")
-	httpPprof         = cgrEngineFlags.Bool(utils.HttpPprofCgr, false, "Enable HTTP pprof profiling")
 	cpuProfDir        = cgrEngineFlags.String(utils.CpuProfDirCgr, utils.EmptyString, "Directory for CPU profiles")
 	memProfDir        = cgrEngineFlags.String(utils.MemProfDirCgr, utils.EmptyString, "Directory for memory profiles")
 	memProfInterval   = cgrEngineFlags.Duration(utils.MemProfIntervalCgr, 15*time.Second, "Interval between memory profile saves")
@@ -548,10 +547,6 @@ func main() {
 	if cfg.ConfigSCfg().Enabled {
 		server.RegisterHttpFunc(cfg.ConfigSCfg().URL, config.HandlerConfigS)
 	}
-	if *httpPprof {
-		server.RegisterProfiler()
-		utils.Logger.Info("<HTTP> registered profiling endpoints at '/debug/pprof/'")
-	}
 
 	// Define internal connections via channels
 	filterSChan := make(chan *engine.FilterS, 1)

cmd/cgr-engine/cgr-engine_flags_test.go

@@ -63,13 +63,6 @@ func TestCgrEngineFlags(t *testing.T) {
 			defaultVal: "",
 			want:       "/run/cgrates/cgrates.pid",
 		},
-		{
-			name:       "httpPprof",
-			flags:      []string{"-http_pprof"},
-			flagVar:    httpPprof,
-			defaultVal: false,
-			want:       true,
-		},
 		{
 			name:       "cpuProfDir",
 			flags:      []string{"-cpuprof_dir", "/tmp/profiling"},

cores/server.go

@@ -188,19 +188,6 @@ func (s *Server) handleRequest(w http.ResponseWriter, r *http.Request) {
 	io.Copy(w, res)
 }
 
-func registerProfiler(mux *http.ServeMux) {
-	mux.HandleFunc("/debug/pprof/", pprof.Index)
-	mux.HandleFunc("/debug/pprof/cmdline", pprof.Cmdline)
-	mux.HandleFunc("/debug/pprof/profile", pprof.Profile)
-	mux.HandleFunc("/debug/pprof/symbol", pprof.Symbol)
-	mux.HandleFunc("/debug/pprof/trace", pprof.Trace)
-}
-
-func (s *Server) RegisterProfiler() {
-	registerProfiler(s.httpMux)
-	registerProfiler(s.httpsMux)
-}
-
 func (s *Server) ServeHTTP(addr, jsonRPCURL, wsRPCURL, promURL, pprofPath string, useBasicAuth bool,
 	userList map[string]string, shdChan *utils.SyncedChan) {
 	s.RLock()

cores/server_test.go

@@ -95,17 +95,6 @@ func TestRegisterHttpFunc(t *testing.T) {
 	rcv.StopBiRPC()
 }
 
-func TestRegisterProfiler(t *testing.T) {
-	cfgDflt := config.NewDefaultCGRConfig()
-	cfgDflt.CoreSCfg().CapsStatsInterval = 1
-	caps := engine.NewCaps(0, utils.MetaBusy)
-	rcv := NewServer(caps)
-
-	rcv.RegisterProfiler()
-
-	rcv.StopBiRPC()
-}
-
 func TestHandleRequestCORSHeaders(t *testing.T) {
 	caps := engine.NewCaps(0, utils.MetaBusy)
 	rcv := NewServer(caps)

docs/cgr-engine.rst

@@ -18,8 +18,6 @@ Able to read the configuration from either a local directory  of *.json* files w
         Configuration directory path (default "/etc/cgrates/")
   -cpuprof_dir string
         Directory for CPU profiles
-  -http_pprof
-        Enable HTTP pprof profiling
   -log_level int
         Log level (0=emergency to 7=debug) (default -1)
   -logger string